1782717 - Back/forward menu's current page menuitem tooltip says "Stay on this page" but the menuitem actually reloads the page

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Shane Hughes [:aminomancer]]

1. Navigate to a page so that you have some navigation history
2. Right-click or click+hold the back/forward button
3. Mouse over the menuitem for the current history entry
4. Tooltip appears with label "Stay on this page"
5. Click the menuitem
6. Page reloads

The label would make sense if the menuitem just did nothing, but since the menuitem reloads the page, I think the tooltip should reflect that. Especially because users can lose form data if they click this menuitem. "Stay on this page" suggests that nothing is going to happen, that it's effectively a "Cancel" button. I don't think a lot of first-time users will expect to lose what they were doing.

Specifically, this tooltip should be changed to "Refresh this page"

Comment 1

[Shane Hughes [:aminomancer]]

Also perhaps this would be a good opportunity to migrate the tabHistory strings to Fluent.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1782717 - Fix back/forward menu tooltip string for current page item to indicate it will reload page. r=Gijs,flod

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34e61e1476ef
Fix back/forward menu tooltip string for current page item to indicate it will reload page. r=Gijs,flod

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/34e61e1476ef

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2022-08-02, on Win 10 x64.
Verified as fixed on Firefox 105.0b5 (20220830185924) on Win 10 x64 and Ubuntu 21.04.
On macOS the functionality is correct but the tooltip is missing. I've verified this on macOS 10.15 and macOS 11. Should I log a new bug for macOS?

Comment 6

[Shane Hughes [:aminomancer]]

(In reply to Giorgia Nichita, Release Desktop QA from comment #5)

Reproduced this issue on an affected Nightly build from 2022-08-02, on Win 10 x64.
Verified as fixed on Firefox 105.0b5 (20220830185924) on Win 10 x64 and Ubuntu 21.04.
On macOS the functionality is correct but the tooltip is missing. I've verified this on macOS 10.15 and macOS 11. Should I log a new bug for macOS?

Thanks for checking! Firefox for macOS uses the macOS native menus API, which doesn't support tooltips afaik. To verify this patch on macOS, you'll have to disable widget.macos.native-context-menus in about:config and restart Firefox.

Comment 7

[Giorgia Nichita, Release Desktop QA]

Verified as well on macOS 10.15 and macOS 11. Closing this bug as verified fixed.