1782719 - All emails in @yahoo.com and AOL account are marked as junk mails, and mark as not junk immediately changes back to junk

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Zhenbo Li]

Attachment: Screenshot 2022-08-02 092902.png

Steps to reproduce:

I'm using Thunderbird Nightly. Current version
105.0a1 (2022-08-01) (64-bit)

Actual results:

In my @yahoo.com account, all emails are marked as junk emails (see attachment)

I checked mail.yahoo.com the emails are in good status

My old emails in my @yahoo.com account are marked as junk as well

My emails in other accounts are not affected

Comment 1

[Zhenbo Li]

If I click "Not Junk" for an email, it will be marked as junk automatically two seconds later

Application Basics
Name: Thunderbird
Version: 105.0a1
Build ID: 20220801104555
Distribution ID:
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Thunderbird/105.0a1
OS: Windows_NT 10.0 19044

Comment 2

[Magnus Melin [:mkmelin]]

That junk status is Thunderbird local. It works by (your) training of it. Mark as not junk for enough of the ones wrongly marked, and it will learn.

Comment 3

[Wayne Mery (:wsmwk)]

https://support.mozilla.org/en-US/kb/thunderbird-and-junk-spam-messages#w_training-the-junk-filter

Comment 4

[Zhenbo Li]

(In reply to Magnus Melin [:mkmelin] from comment #2)

That junk status is Thunderbird local. It works by (your) training of it. Mark as not junk for enough of the ones wrongly marked, and it will learn.

If I click 'Not Junk', the email will be marked as junk again after 2 seconds.

Turning on/off the adaptive junk mail control for this account doesn't help

Comment 5

[Richard Marti (:Paenglab)]

Do you have an extension active that could interfere? Have you tried the Troubleshoot Mode in Help?

Comment 6

[Zhenbo Li]

Thanks, Richard,

(In reply to Richard Marti (:Paenglab) from comment #5)

Do you have an extension active that could interfere?

No extensions.

Have you tried the Troubleshoot Mode in Help?
In troubleshoot mode, this issue still exists

Comment 7

[Zhenbo Li]

(In reply to Zhenbo Li from comment #4)

If I click 'Not Junk', the email will be marked as junk again after 2 seconds.

I recorded my screen to demonstrate it

https://user-images.githubusercontent.com/3221521/182673261-2c64a90e-408c-4019-9394-581cc6b06da3.mp4
(Uploaded by https://github.com/Endle/random_collection/blob/master/README.md)

Comment 8

[Christian Riechers]

I can confirm this. All messages in all folders of the Yahoo IMAP account are affected. Messages do not get moved to the Junk/Bulk folder though.
Resetting the training data and subsequently marking messages 'As Not Junk' has no effect. Also happens in safe mode.
When accessing the account via webmail, no messages are marked as junk on the server.
This started about 2 weeks ago with TB105 daily. Other accounts than Yahoo are not affected. I have not tried this with an AOL account though.

Comment 9

[Dennis Burke]

I'm experiencing the same issue now that 105 is in beta status. Good news, nothing has been moved to Junk on the server. Non-yahoo accounts are not affected.

Comment 10

[Christian Riechers]

AOL accounts are also affected.

Comment 11

[Magnus Melin [:mkmelin]]

From bug 1782347 - https://hg.mozilla.org/comm-central/rev/609f81cdf45703a328280c152e9bd17c1c3f0c0a#l14.34

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: Bug 1782719 - Don't mark NotJunk flagged mails as junk (e.g. Yahoo.). r=benc

Comment 14

[qtrolazyg]

I have the same or similar issue:
I am currently running the Thunderbird beta version 105.0b1 (64-bit) in Windows 11 pro.

When I get mail for my Yahoo account, all messages have a banner that says "Thunderbird thinks this message is junk mail". I have two other accounts that function properly (gmail and outlook). I cleared the settings for the Yahoo (previously set for adaptive junk mail) junk settings and that did not stop the behavior.

Comment 16

[Ben Campbell]

The proposed patch looks good to me. But I just wanted to check: Is there an opposite case that also needs to be accounted for? i.e. marking a mail non-junk locally, and picking the right flag to send to the server? (either "NotJunk" or "NonJunk", depending on yahooness)

Comment 17

[Magnus Melin [:mkmelin]]

It looks like that is taken care of here: https://searchfox.org/comm-central/rev/18c29e9f017de93bb3ad26b29af26a33aec8188d/mailnews/imap/src/nsImapProtocol.cpp#3062

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/07d0c7302ac1
Don't mark NotJunk flagged mails as junk (e.g. Yahoo.). r=benc

Comment 19

[Magnus Melin [:mkmelin]]

Comment on attachment 9291677 [details]
Bug 1782719 - Don't mark NotJunk flagged mails as junk (e.g. Yahoo.). r=benc

[Approval Request Comment]
Regression caused by (bug #): bug 1782347
User impact if declined: yahoo/aol - all non-spam marked as junk
Testing completed (on c-c, etc.): just landed on c-c
Risk to taking this patch (and alternatives if risky): very safe

Comment 20

[Rob Lemley [:rjl]]

Comment on attachment 9291677 [details]
Bug 1782719 - Don't mark NotJunk flagged mails as junk (e.g. Yahoo.). r=benc

[Triage Comment]
Approved for 105.0b2.

Comment 21

[Daniel Darnell [:dandarnell]]

Thunderbird 105.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/05046ef80a2b

Comment 22

[qtrolazyg]

Thank you! Thank you! Thank you for the junk mail fix.