Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe
Categories
(Core :: Graphics: Text, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
We can access gfx.font_rendering.fontconfig.max_generic_substitutions via gfxPlatformGtk::MaxGenericSubstitions(). This is not threadsafe. We should convert it to be StaticPref.
|
Assignee | |
Comment 1•2 years ago
|
||
This pref could be accessed off the main thread with workers. Convert it
to a threadsafe StaticPref.
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32689459fc62 Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame
|
||
Comment 3•2 years ago
|
||
Backed out for causing reftest failures. CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/reftest-sanity/font-download.html == layout/reftests/reftest-sanity/font-default.html | image comparison, max difference: 255, number of differing pixels: 483
|
|
Assignee | |
Comment 4•2 years ago
|
||
Seems to have been the pref handling. I removed that change and it seems to be working:
https://treeherder.mozilla.org/jobs?repo=try&revision=a1a9c786f1912aed93841c24b339357433b37e52
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4e889c6bd96 Make gfx.font_rendering.fontconfig.max_generic_substitutions threadsafe. r=jfkthame
Backout by mlaza@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/3d354d73dc2a Backed out changeset 32689459fc62 for causing reftest failures. CLOSED TREE
|
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Description
•