Closed
Bug 1782765
Opened 2 years ago
Closed 2 years ago
rust-xpcom: RefPtrs in arrays of interfaces are incorrectly non-nullable
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
When generating code for arrays of interfaces from the rust-xpidl compiler, the type was declared incorrectly as ThinVec<RefPtr<T>> instead of ThinVec<Option<RefPtr<T>>> meaning that nullptr values in the array would be handled incorrectly. We should fix this.
|
Assignee | |
Comment 1•2 years ago
|
||
When generating code for arrays of interfaces from the rust-xpidl
compiler, the type was declared incorrectly as ThinVec<RefPtr<T>>
instead of ThinVec<Option<RefPtr<T>>> meaning that null values in the
array would be handled incorrectly.
This patch fixes this code generation mistake and updates crates using
the interface to handle null values correctly.
|
|
Assignee | |
Updated•2 years ago
|
Summary: rust-xpcom: RefPtrs in arrays of interfaces are broken incorrectly non-nullable → rust-xpcom: RefPtrs in arrays of interfaces are incorrectly non-nullable
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39a08f3e83df Fix nullability of arrays of interfaces in Rust, r=xpcom-reviewers,necko-reviewers,mccr8,valentin
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•