Closed Bug 1782783 Opened 2 years ago Closed 8 months ago

Intermittent accessible/tests/browser/events/browser_test_focus_urlbar.js | single tracking bug

Categories

(Core :: Disability Access APIs, defect, P5)

Product:
Core
Component:
Disability Access APIs
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- wontfix
firefox110 --- unaffected
firefox111 --- wontfix
firefox112 --- wontfix
firefox117 --- wontfix
firefox118 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dao)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disabled])

Attachments

(2 files, 1 obsolete file)

Bug 1782783 - disable browser_test_focus_urlbar.js on linux for frequent failures. patch re-made to solve landing conflicts r=#intermittent-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1782783 - Re-enable browser_test_focus_urlbar.js on Linux. r=Jamie
48 bytes, text/x-phabricator-request
Details | Review

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=386138042&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PqRBSEeJSOSqCBGelBL03w/runs/1/artifacts/public/logs/live_backing.log

[task 2022-08-02T16:34:27.968Z] 16:34:27     INFO - TEST-START | accessible/tests/browser/events/browser_test_focus_urlbar.js
[task 2022-08-02T16:34:28.284Z] 16:34:28     INFO - GECKO(1780) | must wait for focus in content
[task 2022-08-02T16:35:12.999Z] 16:35:12     INFO - TEST-INFO | started process screenshot
[task 2022-08-02T16:35:13.056Z] 16:35:13     INFO - TEST-INFO | screenshot: exit 0
[task 2022-08-02T16:35:13.057Z] 16:35:13     INFO - Buffered messages logged at 16:34:27
[task 2022-08-02T16:35:13.057Z] 16:35:13     INFO - Entering test bound 
[task 2022-08-02T16:35:13.058Z] 16:35:13     INFO - Buffered messages logged at 16:34:28
[task 2022-08-02T16:35:13.058Z] 16:35:13     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Actually remote browser - 
[task 2022-08-02T16:35:13.059Z] 16:35:13     INFO - Buffered messages finished
[task 2022-08-02T16:35:13.060Z] 16:35:13     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out - 
[task 2022-08-02T16:35:13.333Z] 16:35:13     INFO - GECKO(1780) | MEMORY STAT | vsize 964MB | vsizeMaxContiguous 325MB | residentFast 223MB | heapAllocated 218MB
[task 2022-08-02T16:35:13.334Z] 16:35:13     INFO - TEST-OK | accessible/tests/browser/events/browser_test_focus_urlbar.js | took 45356ms
[task 2022-08-02T16:35:13.344Z] 16:35:13     INFO - checking window state
[task 2022-08-02T16:35:13.356Z] 16:35:13     INFO - TEST-START | accessible/tests/browser/events/browser_test_panel.js

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE

New failure instance: https://treeherder.mozilla.org/logviewer?job_id=390955059&repo=autoland

Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

The recent failures from 06.12.2022 was caused by bug 1803873( it got backed out)
https://hg.mozilla.org/integration/autoland/rev/a00edd389ee609daf30e9fbb6acc23d686d0f19a

There have been 47 total failures in the last 7 days, recent failure log.
Affected platforms are:

  • linux1804-64-asan-qr
  • linux1804-64-qr
  • linux1804-64-shippable-qr
  • linux1804-64-tsan-qr
  • macosx1015-64-qr
[task 2023-02-03T18:46:43.658Z] 18:46:43     INFO - TEST-PASS | accessible/tests/browser/events/browser_test_focus_urlbar.js | Selected element must be selectable! - 
[task 2023-02-03T18:46:43.658Z] 18:46:43     INFO - Ensuring focus of another autocomplete item on up arrow
[task 2023-02-03T18:46:43.659Z] 18:46:43     INFO - Buffered messages finished
[task 2023-02-03T18:46:43.660Z] 18:46:43     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/browser/events/browser_test_focus_urlbar.js | Test timed out - 
[task 2023-02-03T18:46:43.826Z] 18:46:43     INFO - GECKO(5849) | MEMORY STAT | vsize 130561063MB | residentFast 1359MB
[task 2023-02-03T18:46:43.830Z] 18:46:43     INFO - TEST-OK | accessible/tests/browser/events/browser_test_focus_urlbar.js | took 120802ms
Flags: needinfo?(jteh)
Whiteboard: [stockwell needswork:owner]

Dao, do you know if any of the recent URL bar work could have caused a spike in these test failures? I can't think of anything that has changed in the a11y module that would impact this.

Flags: needinfo?(jteh) → needinfo?(dao+bmo)

That changeset only impacts linting. It should have no other impact on (non-lint) tests.

Flags: needinfo?(jteh)

This actually popped up with landing of Bug 1811870 here. It was backed out on a couple of occasions so that's why the earlier failures.
Given that now it's on the disable recommended list it should be taken care of or it will be disabled in the coming days. It has 184 total failures in the last 30 days. If Dao doesn't respond, could you please redirect this to someone else to fix it? Thank you.

Flags: needinfo?(jteh)
Regressed by: 1811870
Assignee: nobody → nbeleuzu
Attachment #9317182 - Attachment description: WIP: Bug 1782783 - Disable browser_test_focus_urlbar.js on Linux. → Bug 1782783 - Disable browser_test_focus_urlbar.js on Linux.

Added a patch to disable the test on linux in case we will need it

I reached out to Dao on Slack as well. I don't know who else to ping, as Dao was the implementer, but I'll see who I can find if I don't get a response in the next day or two.

Flags: needinfo?(jteh)

Should we land the disable patch until there will be a fix?

Flags: needinfo?(jteh)

I understand the need to stop the bleeding here. I guess we can disable this and re-enable it once it's fixed. At least it's not broken on all platforms at this stage.

Flags: needinfo?(jteh)

Set release status flags based on info from the regressing bug 1811870

status-firefox110: --- → unaffected
status-firefox111: --- → affected
status-firefox112: --- → affected
status-firefox-esr102: --- → unaffected
Attachment #9317182 - Attachment is obsolete: true

I made a new disable patch for this, because the one from comment 35(which is now abandoned) had some landing conflicts. We are going to land the new disable patch. Please re-enable the test when fixing the issue from this bug.
Thank you!

Pushed by imoraru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d6f9ea5ffff
disable browser_test_focus_urlbar.js on linux for frequent failures. patch re-made to solve landing conflicts r=aryx
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Depends on: 1818994

So I just discussed this test with Jamie, ran the test locally on Ubuntu in verify mode and it passed all the time. But that doesn't necessarily mean much since most of the failures seem to have been in debug builds and mine isn't one. I sent a patch to try that re-enables the patch on Linux to see what happens:
https://treeherder.mozilla.org/jobs?repo=try&revision=2762a3089e427279669d32b76708a6bd4cbb51cb

There's a chance the intermittent failure is resolved by now for unknown reasons. There's also a chance it isn't, and Jamie is currently looking into making the test more robust e.g. by waiting for accessibility events here: https://searchfox.org/mozilla-central/rev/7dced5144155b9d458badbbeeed6258626fb8da1/accessible/tests/browser/events/browser_test_focus_urlbar.js#244-246

Flags: needinfo?(dao+bmo)

(In reply to Dão Gottwald [:dao] from comment #55)

So I just discussed this test with Jamie, ran the test locally on Ubuntu in verify mode and it passed all the time. But that doesn't necessarily mean much since most of the failures seem to have been in debug builds and mine isn't one. I sent a patch to try that re-enables the patch on Linux to see what happens:
https://treeherder.mozilla.org/jobs?repo=try&revision=2762a3089e427279669d32b76708a6bd4cbb51cb

There's a chance the intermittent failure is resolved by now for unknown reasons.

Scrolling back through the robot's comments, it also looks like the intermittent failure has stopped happening on macOS about five months ago, which does seem to indicate that the failure went away.

Assignee: nbeleuzu → dao+bmo
Keywords: leave-open

(In reply to Dão Gottwald [:dao] from comment #55)

So I just discussed this test with Jamie, ran the test locally on Ubuntu in verify mode and it passed all the time. But that doesn't necessarily mean much since most of the failures seem to have been in debug builds and mine isn't one. I sent a patch to try that re-enables the patch on Linux to see what happens:
https://treeherder.mozilla.org/jobs?repo=try&revision=2762a3089e427279669d32b76708a6bd4cbb51cb

TV came back green on Linux debug: https://treeherder.mozilla.org/jobs?repo=try&revision=2762a3089e427279669d32b76708a6bd4cbb51cb&selectedTaskRun=QKh2qFmyQOCBNdG2NjpYjg.0

Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/585b4184d987
Re-enable browser_test_focus_urlbar.js on Linux. r=Jamie

https://hg.mozilla.org/mozilla-central/rev/585b4184d987

Status: REOPENED → RESOLVED
Closed: 2 years ago → 8 months ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
No longer duplicate of this bug: 1492259
No longer depends on: 1818994
See Also: → 1818994
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: