Open Bug 1782928 Opened 3 years ago Updated 3 years ago

code coverage shows dead code in MemoryTelemetry.cpp

Categories

(Core :: XPCOM, task)

Product:

Component:

Type:

task

Priority:

Not set

Severity:

--

Tracking

()

Status:

NEW

People

(Reporter: florian, Unassigned)

Details

Florian Quèze [:florian]

Reporter

Description

•

3 years ago

Looking at MemoryTelemetry.cpp in searchfox, I noticed:

MemoryTelemetry::GetUniqueSetSize has no caller.
MemoryTelemetry::GatherReports is never called with a non-null aCompletionCallback parameter.

Nika Layzell [:nika] (ni? for response)

Updated

•

3 years ago

Type: defect → task

Beth Rennie [:beth] (she/her)

Comment 1

•

3 years ago

The second claim seems to be false:
https://searchfox.org/mozilla-central/rev/75da1dd5d4b9b991f919a41594194eab93cdef62/toolkit/components/telemetry/core/Telemetry.cpp#1672-1673

You need to log in before you can comment on or make changes to this bug.