Closed Bug 1783011 Opened 2 years ago Closed 2 years ago

[Colorway Closet] Limit the modal size to something reasonable

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: polish, Whiteboard: [fidefe-colorway-closet])

Attachments

(1 file)

Bug 1783011 - [Colorway Closet] Limit the modal size to something reasonable. r=gijs
48 bytes, text/x-phabricator-request
Details | Review

It looks like the modal gets a width of at least 80% of the view port based on this line and the surrounding code:
https://searchfox.org/mozilla-central/rev/560bbebd595cf2f6a9861f3f67dd0739f4c4c559/toolkit/modules/SubDialog.jsm#481

80% is a lot on larger screen and window sizes, potentially way more than we need for the content of our modal which can end up looking a bit lost. We should find a way to limit the size.

Severity: -- → S4
Keywords: polish
Priority: -- → P2
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dba4dc940ca9
[Colorway Closet] Limit the modal size to something reasonable. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/dba4dc940ca9

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Regressions: 1783887
Regressions: 1784488
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: