Closed Bug 1783087 Opened 2 months ago Closed 2 months ago

Build fails on Windows with --disable-backgroundtasks

Categories

(Toolkit :: Background Tasks, defect, P1)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- fixed
firefox103 --- wontfix
firefox104 --- fixed
firefox105 --- fixed

People

(Reporter: mathew.hodson, Assigned: mathew.hodson)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

If I add --disable-backgroundtasks to my mozconfig file, the build fails looking for a header.

 3:44.30 widget/windows
 3:50.73 In file included from Unified_cpp_widget_windows1.cpp:119:
 3:50.73 C:/Users/Mathew/source/repos/mozilla-central/widget/windows/nsAppShell.cpp(20,10): fatal error: 'mozilla/BackgroundTasks.h' file not found
 3:50.73 #include "mozilla/BackgroundTasks.h"
 3:50.74          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
 3:50.74 1 error generated.
 3:50.75 mozmake[4]: *** [C:/Users/Mathew/source/repos/mozilla-central/config/rules.mk:669: Unified_cpp_widget_windows1.obj] Error 1
Component: Untriaged → Background Tasks
Product: Firefox → Toolkit
Regressed by: 1753603
Assignee: nobody → mathew.hodson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/abb002a29e24
Fix build with --disable-backgroundtasks. r=nalexander DONTBUILD
Severity: -- → S2
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mathew.hodson)

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #5)

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

No, this doesn't deserve uplift.

Flags: needinfo?(mathew.hodson)
You need to log in before you can comment on or make changes to this bug.