1783087 - Build fails on Windows with --disable-backgroundtasks

Status: RESOLVED FIXED

(Toolkit :: Background Tasks, defect, P1)

Description

[Mathew Hodson]

If I add --disable-backgroundtasks to my mozconfig file, the build fails looking for a header.

 3:44.30 widget/windows
 3:50.73 In file included from Unified_cpp_widget_windows1.cpp:119:
 3:50.73 C:/Users/Mathew/source/repos/mozilla-central/widget/windows/nsAppShell.cpp(20,10): fatal error: 'mozilla/BackgroundTasks.h' file not found
 3:50.73 #include "mozilla/BackgroundTasks.h"
 3:50.74          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
 3:50.74 1 error generated.
 3:50.75 mozmake[4]: *** [C:/Users/Mathew/source/repos/mozilla-central/config/rules.mk:669: Unified_cpp_widget_windows1.obj] Error 1

Comment 1

[Mathew Hodson]

Attachment: Bug 1783087 - Fix build with --disable-backgroundtasks. r?mossop

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753603

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abb002a29e24
Fix build with --disable-backgroundtasks. r=nalexander DONTBUILD

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/abb002a29e24

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #5)

The patch landed in nightly and beta is affected.
:mathew.hodson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

No, this doesn't deserve uplift.

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a4bd2998ae2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/261174b0edf5