1783095 - [CTW] A wrapping HTML label isn't included in cached relations

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

Test case:
data:text/html,<label>Name: <input></label>
The input should have the label included in its LABELLED_BY relation, but it doesn't.

I was originally thinking we'd need to add additional code for this. However, the relations cache push already calls labelEl->GetControl(), which I think should be enough to get the right control, even if it's associated via ancestry instead of the for attribute.

I think the reason this isn't working is the same bug that makes <label for> fail for an initial cache push; i.e. the tag not being present yet. So, the fix for that bug should hopefully fix this one. Nevertheless, I'm filing this because this needs to be verified and a test added for it.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1783095: Add relation caching test for input wrapped in <label> r?Jamie

Depends on D153798

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e1db528f51e
Add relation caching test for input wrapped in <label> r=Jamie

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8e1db528f51e