Closed Bug 1783095 Opened 2 years ago Closed 2 years ago

[CTW] A wrapping HTML label isn't included in cached relations

Categories

(Core :: Disability Access APIs, defect)

defect

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: Jamie, Assigned: morgan)

References

Details

(Whiteboard: [ctw-m2])

Attachments

(1 file)

Test case:
data:text/html,<label>Name: <input></label>
The input should have the label included in its LABELLED_BY relation, but it doesn't.

I was originally thinking we'd need to add additional code for this. However, the relations cache push already calls labelEl->GetControl(), which I think should be enough to get the right control, even if it's associated via ancestry instead of the for attribute.

I think the reason this isn't working is the same bug that makes <label for> fail for an initial cache push; i.e. the tag not being present yet. So, the fix for that bug should hopefully fix this one. Nevertheless, I'm filing this because this needs to be verified and a test added for it.

Depends on: 1783096
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e1db528f51e
Add relation caching test for input wrapped in <label> r=Jamie
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.