178313 - /names command fails to show output for other channels

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021029 Phoenix/0.4

When using the /names command, the returned output from the server fails to be
displayed unless it's for the current channel, or you've done "/names" in the
channel in question.

Reproducible: Always

Steps to Reproduce:
1. Join the IRC server specified (though any should do).
2. Join two channels (suggested one: #testing1 and #testing2).
3. In #testing1, do the command "/names #testing2".
4. Then switch to #testing2, and do "/names".
5. Switch back to #testing1, and do "/names #testing2" again.
Actual Results:  
First "/names #testing2" seems to do nothing.
Second "/names #testing2" shows user list for #testing2, albeit in the wrong tab. :)

Expected Results:  
Both times should show the output, preferably always in the current tab.

Comment 1

[Samuel Sieb]

What appears to happening here is that chatzilla tries to send the /names output
to the channel you're checking, and if that view doesn't exist, it just goes away.

Comment 2

[Koike Kazuhiko]

Attachment: patch

Removed unnecessary CIRCChannel.pendingNamesReply.

Comment 3

[Robert Ginda]

Comment on attachment 117296 [details] [diff] [review]
patch

pendingNamesReply is not useless.  That's what keeps the NAMES messages sent in
response to a JOIN from showing up in the message window.

With this patch, join a channel that has users, and you'll see something
like...

[INFO]	Channel view for “#chatzilla” opened.
-->|	YOU have joined #chatzilla
=-=	Topic for #chatzilla is “Welcome to #chatzilla. *Questions about
ChatZilla only, please. Click <irc://undernet/chatzone> for general chat.* For
bug fixes and new features, upgrade to version 0.8.24 at
<http://www.hacksrus.com/~ginda/chatzilla/>”
=-=	Topic for #chatzilla was set by rginda on Fri Mar 07 2003 15:42:38
GMT-0800 (PST)
===	rginda_ Silver juna_work @ssieb_work Lissyx @rginda moj Isomer
@ssieb_home @killer
---	End of /NAMES list.

Comment 4

[Koike Kazuhiko]

Attachment: patch v2

Comment 5

[Koike Kazuhiko]

Attachment: patch v3

The previous patch doesn't consider multibyte channel names.

Comment 6

[Koike Kazuhiko]

Attachment: patch v4

Added the channel name before the nicknames.
Removed "End of /NAMES list" message. It's meaningless.

Comment 7

[Robert Ginda]

I don't think it's meaningless.  Most irc clients show it, and it lets the user
know the server is done sending names.  If the channel has many users, there
will be multiple names replies.  If the server load is high, there might be a
delay between the names replies.  The end of names message lets you know it's
all done.  Other than that the patch looks great.

Comment 8

[Koike Kazuhiko]

Attachment: patch v5

Restored "End of /NAMES list" message and added the channel name
before it.

Comment 9

[Robert Ginda]

Comment on attachment 117774 [details] [diff] [review]
patch v5

r=rginda

Comment 10

[Koike Kazuhiko]

The patch was checked in.