Closed Bug 1783279 Opened 1 year ago Closed 1 year ago

Mobile promo text size

Categories

(Firefox :: Firefox View, defect, P2)

Product:
Firefox
Component:
Firefox View
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox105 --- wontfix
firefox106 --- wontfix
firefox107 --- verified
firefox108 --- verified

People

(Reporter: jberman, Assigned: cmkm)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view] [Interface])

Attachments

(2 files)

Bug 1783279 - Adjust mobile promo font sizes r?Gijs
48 bytes, text/x-phabricator-request
Details | Review
Bug 1783279 - Readjust mobile promo description font size r?Gijs
48 bytes, text/x-phabricator-request
Details | Review

Actual - Last active tab Tab Name text is 15 px, but appears smaller than “Grab tabs…” in mobile promo
Expected - Last active tab Tab Name text and “Grab tabs…” mobile promo
is 15 px

Design file - https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone?node-id=5555%3A94358

Severity: -- → S3
Priority: -- → P2
Keywords: perf:frontend
Keywords: perf:frontend
Whiteboard: [fidefe-2022-mr1-firefox-view] → [fidefe-2022-mr1-firefox-view] [Interface]
Assignee: nobody → cmeador
Status: NEW → ASSIGNED
Pushed by cmeador@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fa8b2f25597
Adjust mobile promo font sizes r=Gijs

First landed patch adjusted the mobile promo heading size down to 15px and the body text down to 13px, per spec. After a convo with Josh, the body text size was reverted to 15px in a second patch. The mobile promo header and body text should now both be 15px.

Pushed by cmeador@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43c73571e973
Readjust mobile promo description font size r=Gijs

https://hg.mozilla.org/mozilla-central/rev/1fa8b2f25597

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

status-firefox106: --- → affected

The patch landed in nightly and beta is affected.
:cmkm, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(cmeador)
Flags: needinfo?(cmeador)
Flags: qe-verify+

Verified as Fixed in our latest Nightly 108.0a1 (2022-10-20) as well as our latest Beta 107.0b3.

Status: RESOLVED → VERIFIED
status-firefox107: fixed → verified
status-firefox108: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.