Update opus to new version 997fdf54e781ae1c04dee42018f35388a04fe483 from 2022-08-04 19:02:02
Categories
(Core :: Audio/Video: Playback, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: update-bot, Assigned: kinetik)
Details
(Whiteboard: [3pl-filed][task_id: TrUkAAqXRb6WCLYR8NtH8Q])
Attachments
(1 file)
This update covers 1 commits:
997fdf54e781ae1c04dee42018f35388a04fe483 by Jean-Marc Valin
https://gitlab.xiph.org/xiph/opuscommit/997fdf54e781ae1c04dee42018f35388a04fe483
Authored: 2022-08-04 18:59:37 -0400
Committed: 2022-08-04 19:02:02 -0400
Change pitch scaling behavior wrt nFramesPerPacket
Not sure if it was the original intent, but we now reduce the
loss percentage threshold for pitch scaling as 1/nFramesPerPacket
since only the first frame will have pitch scaling anyway.
As a side effect, this brings back the original behavior of
disabling pitch scaling for 0% loss.
Files Modified:
- silk/fixed/LTP_scale_ctrl_FIX.c
- silk/float/LTP_scale_ctrl_FLP.c
|
Reporter | |
Comment 1•2 years ago
|
||
| TrUkAAqXRb6WCLYR8NtH8Q | ||
I've submitted a try run for this commit: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3aabd59f718bc38686bfdcc1cf3e60931f5f221
|
|
Reporter | |
Comment 2•2 years ago
|
||
|
|
Reporter | |
Comment 3•2 years ago
|
||
| UfqIX_VOTuCF6ZiROOPrEg | ||
All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...
Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/968eabf16898 Update opus to 997fdf54e781ae1c04dee42018f35388a04fe483 r=kinetik
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•