Closed Bug 1783302 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35347 - Rename hoverpopup to popuphovertarget, to align with other invokers

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox106 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35347 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35347
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Rename hoverpopup to popuphovertarget, to align with other invokers

There wasn't a resolution for this, but this naming aligns much better
with the other invokers, such as popuptoggletarget, popupshowtarget,
etc. It's not exactly parallel, in that the others describe what
happens to the target (e.g. toggle or show), while this describes what
needs to happen to the element with the attribute. But still this seems
better.

Bug: 1307772
Change-Id: Id690a4a03013f3e9f6395b4614f04a5cabea19e9
Reviewed-on: https://chromium-review.googlesource.com/3812260
WPT-Export-Revision: b9fcf898309e1f731a89fa9b79a0917e337a7994

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 45 subtests

Status Summary

Firefox

OK : 2
FAIL: 49

Chrome

OK : 2
PASS: 36
FAIL: 13

Safari

OK : 2
FAIL: 49

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-hover-hide.tentative.html [wpt.fyi]
    • The hover-pop-up-hide-delay causes a pop-up to be hidden after a delay: FAIL (Chrome: FAIL, Safari: FAIL)
    • hovering the pop-up keeps it from being hidden: FAIL (Chrome: FAIL, Safari: FAIL)
    • hovering a popuphovertarget invoking element keeps the pop-up from being hidden: FAIL (Chrome: FAIL, Safari: FAIL)
    • hovering a popuptoggletarget invoking element keeps the pop-up from being hidden: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/popups/popup-hoverpopup-attribute.tentative.html [wpt.fyi]
    • popuphovertarget attribute shows a pop-up with popup=auto, invokerType=plain: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=auto, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=auto, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=auto, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=auto, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=auto, invokerType=nested: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=auto, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=auto, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=auto, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=auto, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=auto, invokerType=nested-offset: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=auto, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=auto, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=auto, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=auto, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=hint, invokerType=plain: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=hint, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=hint, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=hint, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=hint, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=hint, invokerType=nested: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=hint, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=hint, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=hint, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=hint, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=hint, invokerType=nested-offset: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=hint, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=hint, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=hint, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=hint, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=manual, invokerType=plain: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=manual, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=manual, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=manual, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=manual, invokerType=plain): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=manual, invokerType=nested: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=manual, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=manual, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=manual, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=manual, invokerType=nested): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute shows a pop-up with popup=manual, invokerType=nested-offset: FAIL (Chrome: FAIL, Safari: FAIL)
    • popuphovertarget hover-pop-up-delay is respected (popup=manual, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is already showing (popup=manual, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when pop-up is moved out of the document (popup=manual, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
    • popuphovertarget attribute does nothing when target changes (popup=manual, invokerType=nested-offset): FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ef55d3b0548 [wpt PR 35347] - Rename hoverpopup to popuphovertarget, to align with other invokers, a=testonly https://hg.mozilla.org/integration/autoland/rev/6588eb230a2c [wpt PR 35347] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/5ef55d3b0548
https://hg.mozilla.org/mozilla-central/rev/6588eb230a2c

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox106: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.