1783452 - Option to disable "QuickActions" specific buttons or whole feature is not present in Firefox's Settings

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Option to disable "QuickActions" specific buttons or whole feature is not present in Firefox's Settings.

Steps to reproduce:

1. Open latest Mozilla Firefox Nighty 105.0a1 (2022-08-05) (64-bit)
2. Select Address Bar
3. Notice 5 new buttons ("View Add-ons", "View Bokmarks", "Clear History", "Open Downloads", "Open Inspector")
4. Open Firefox's Settings and look for option to hide them from there
5. Notice that option to disable "QuickActions" specific buttons or whole feature is not present in Firefox's Settings

Observed results:
Option to disable "QuickActions" specific buttons or whole feature is not present in Firefox's Settings.

Expected results:
Option to disable "QuickActions" specific buttons or whole feature is present in Firefox's Settings.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Since there already is an issue handling the enable/disable the feature, I'll also add that the about:preferences#search option to enable/disable the feature should also remove/hide it from the about:preferences#search / Search shortcuts.
Also, given that this feature will be first an experiment, maybe also a different pref to enable/disable the quickactions UI about:preferences#search option.

Maybe also telemetry on enable/disable?

Dale, can you take a look at this issue and clarify what are the expectancies in regards to this topic?

Comment 2

[James Teow [:jteow]]

Adrian, I'm going to needsinfo Dale because he's been the main engineer on this project.

Comment 3

[Adrian Florinescu [:aflorinescu]]

(In reply to James Teow [:jteow] from comment #2)

Adrian, I'm going to needsinfo Dale because he's been the main engineer on this project.

Just realized aswell that I confused the features :) and got mid-air conflict :). Thanks for the redirect.

Comment 4

[Dale Harvey (:daleharvey)]

Adrian, thanks yeh that sums up what the enabling + setting options should look like. This slipped through the crack a little as the settings have been discussed and specced but should have been filed and probably implemented before enabling, but will use this bug to implement them, thanks.

Comment 5

[Adrian Florinescu [:aflorinescu]]

Attachment: quickactions_settings.jpg

Adding the UX spec for the option.

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: Bug 1783452 - Add section in preferences to enable/disable QuickActions. r=adw

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Bug 1783452 - Add section in preferences to enable/disable QuickActions. r=adw

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a40754091a30
Add section in preferences to enable/disable QuickActions. r=adw,fluent-reviewers,preferences-reviewers,flod,mstriemer

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a40754091a30

Comment 11

[Adrian Florinescu [:aflorinescu]]

Verified the addition of option to disable the QuickActions functionality in about:preferences#privacy / Address bar with 105.0a1 (2022-08-22) on Windows 10, Ubuntu 22.04 and Mac 11. Spinned off bug 1786297 for the follow-up work.