urichecker crashes things

RESOLVED FIXED

Status

()

Core
Networking
--
critical
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({crash})

Trunk
x86
Windows 2000
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.52 KB, patch
Charles Manske
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
found while working on bug 155524
entering this into xpcshell (11/04-08):
Components.classes["@mozilla.org/network/urichecker;1"].createInstance(Components.interfaces.nsIURIChecker).baseRequest
crashes.
(Assignee)

Comment 1

16 years ago
fwiw. there's a 
###!!! ASSERTION: null parameter: 'aSource', file
../../../dist/include/xpcom/nsISupportsUtils.h, line 262

nsURIChecker::GetBaseRequest
[c:/builds/seamonkey/mozilla/netwerk/base/src/nsURIChecker.cpp, line 148]
XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 106]

145               nsURIChecker::GetBaseRequest(nsIRequest** aRequest)
146               {
147                   return CallQueryInterface(mChannel, aRequest);
148               }
the fix is simple :)
Assignee: new-network-bugs → timeless
Keywords: crash
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

16 years ago
Created attachment 105138 [details] [diff] [review]
checks
> nsURIChecker::GetBaseRequest(nsIRequest** aRequest)

Null the out param out too?  sr=bzbarsky with that.
(Assignee)

Comment 4

16 years ago
Created attachment 105213 [details] [diff] [review]
checks + null outs
Attachment #105138 - Attachment is obsolete: true

Comment 5

16 years ago
Comment on attachment 105213 [details] [diff] [review]
checks + null outs

r=cmanske
Attachment #105213 - Flags: review+
(Assignee)

Comment 6

16 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
timeless: any chance you can put in some xpc shell output that shows this as fixed?
You need to log in before you can comment on or make changes to this bug.