Closed Bug 1783508 Opened 2 years ago Closed 2 years ago

Activity Manager doesn't show "Get Messages" activity when no new mails found - when "Leave messages on server" is turned off

Categories

(Thunderbird :: Mail Window Front End, defect)

Thunderbird 102
defect

Tracking

(thunderbird_esr102+ fixed, thunderbird104 affected)

RESOLVED FIXED
105 Branch
Tracking Status
thunderbird_esr102 + fixed
thunderbird104 --- affected

People

(Reporter: rho-bot, Assigned: rnons)

Details

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

  • Start Thunderbird
  • Click "Get Messages" (if not configured as check on startup)
  • Open Activity Manager window

Actual results:

Activity Manager window keeps empty.
No entries for general POP3 mailcheck if there are no new messages to DL.
In case there were new messages to DL, just sync-DL entry is shown.

Expected results:

I expected to see the entries for general POP3 mailcheck, like in TB91 and before.

Component: Untriaged → Mail Window Front End
Flags: needinfo?(remotenonsense)

This should have been fixed by bug 1777892, and released in TB 102.1.0. Can you check your version, and try again after upgrading? Thanks.

Flags: needinfo?(remotenonsense)

Issue present on TB 102.1.0/102.1.1/102.1.2
bug 1777892 fixed missing AM message, when pop3 messages download.
This Bug report is for missing entries in AM when pop3 check is performed without any new messages to download.

Attached image pop3_activity.jpg

Well, it's the same thing, the code is at https://searchfox.org/comm-central/rev/30b643d4b2d25ac9d72567bc0af3f08177d2fd1d/mail/components/activity/modules/pop3Download.jsm#99,119

Can you set mail.activity.loglevel to All, search for onDownload in Console , after click "Get Messages", do you see

mail.activity: in onDownloadStarted pop3Download.jsm:63:14
mail.activity: in onDownloadCompleted pop3Download.jsm:100:14
Attached image Mai-Activityl.PNG

This is my current console output, no traces of onDownload in log...
But clicking "Get Messages", I can see the "xxx@xxx.xx: There are no new messages" in the bottom status bar of the main window.

I think I've found the problem, you have turned off "Leave messages on server", right? Pop3Client early returns if the total message number is 0 in STAT response, https://searchfox.org/comm-central/rev/4e7b7cdfaab079c4441c02e6a7c9405e86b6e6ec/mailnews/local/src/Pop3Client.jsm#869-870,886

Will make a fix soon, thanks.

Assignee: nobody → remotenonsense
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Yep, "Leave messages on server" is turned off. Nice that you found the issue that quickly :)

Another short question, as I'm not sure on old behavior:
When sending emails, I also see smtp message in status bar, but no entry in AM. Intended, or maybe another bug?

I also see smtp message in status bar, but no entry in AM. Intended, or maybe another bug?

Please file another bug, it's also broken by me, I will take a look later. Thanks.

Summary: Activity Manager doesn't show "Get Messages" activity when no new mails found → Activity Manager doesn't show "Get Messages" activity when no new mails found - when "Leave messages on server" is turned off

(In reply to Ping Chen (:rnons) from comment #7)

I also see smtp message in status bar, but no entry in AM. Intended, or maybe another bug?

Please file another bug, it's also broken by me, I will take a look later. Thanks.

Created new bug 1784173

Target Milestone: --- → 105 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/cd45136da351
Notify activity manager when STAT returns 0 message in Pop3Client. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

@Magnus
Currently rolled out update to TB102.2.0 didn't solve the issue. Maybe PR was too late for production?
When / which version I can expect the merge/fix?
Unfortunately, I'm lost with above Tracking info...

Yes it's not yet on 102. Once it is, you'll see the thunderbird_esr102 flag above set to "fixed"

[Approval Request Comment]
Regression caused by (bug #): bug 1707548
User impact if declined: In some cases, "No messages to download" is not shown in the activity manager for pop3 servers
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Attachment #9291888 - Flags: approval-comm-esr102?

Comment on attachment 9291888 [details] [diff] [review]
1783508-esr102.patch

[Triage Comment]
Approved for esr102

Attachment #9291888 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: