1783565 - Enable more ESLint rules for netwerk

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Mark Banner (:standard8)]

There's still a few rules that are disabled in netwerk that we want to enable. This will help with consistency with the rest of the tree, as well as helping to show up potential issues in new code.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=9e8459ac2e1a6e4c140cc71fd8d46c19cc82ef20

The windows failures there appear to be bug 1775761.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Enable ESLint rules for no-arbitrary-setTimeout, no-define-cc-etc and consistent-return on netwerk/. r?dragana

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Enable ESLint rules no-eval, no-nested-ternary, no-throw-literal for the rest of netwerk. r?dragana

Depends on D153895

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Enable ESLint rule no-redeclare on the rest of netwerk. r?dragana

Depends on D153896

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Enable ESLint rule no-global-assign for the rest of netwerk. r?dragana

Depends on D153897

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Set ESLint rule no-shadow to warning for where it is turned on in netwerk. r?dragana

Depends on D153898

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e11b0d6e731
Enable ESLint rules for no-arbitrary-setTimeout, no-define-cc-etc and consistent-return on netwerk/. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/cc2d5eaf69d2
Enable ESLint rules no-eval, no-nested-ternary, no-throw-literal for the rest of netwerk. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/3523c3cede7d
Enable ESLint rule no-redeclare on the rest of netwerk. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/289d233f1266
Enable ESLint rule no-global-assign for the rest of netwerk. r=dragana,necko-reviewers

Comment 8

[Atila Butkovits]

Backed for causing failures at test_origin.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1875b970dc64011b8a0b093ed432d0117d9758cb

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=AGW2uosbT4OgX-BE1xyQ6g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=289d233f126631f37731ddaaa46337118de3754b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=386673343&repo=autoland&lineNumber=5283

Comment 9

[Mark Banner (:standard8)]

Bah, xpcshell-tests didn't run on my try push :( Will take a look and re-fix.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cc59ef5a163
Enable ESLint rules for no-arbitrary-setTimeout, no-define-cc-etc and consistent-return on netwerk/. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/44754d53368c
Enable ESLint rules no-eval, no-nested-ternary, no-throw-literal for the rest of netwerk. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/2bca60bdf1d8
Enable ESLint rule no-redeclare on the rest of netwerk. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/25a79e2dc30a
Enable ESLint rule no-global-assign for the rest of netwerk. r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/4303f3ec286a
Set ESLint rule no-shadow to warning for where it is turned on in netwerk. r=dragana

Comment 11

[Mark Banner (:standard8)]

Attachment: Bug 1783565 - Fix ESlint issue in netwerk/test/unit/head_servers.js due to consistent-return).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7ffff73891a
Fix ESlint issue in netwerk/test/unit/head_servers.js due to consistent-return). CLOSED TREE

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7cc59ef5a163
https://hg.mozilla.org/mozilla-central/rev/44754d53368c
https://hg.mozilla.org/mozilla-central/rev/2bca60bdf1d8
https://hg.mozilla.org/mozilla-central/rev/25a79e2dc30a
https://hg.mozilla.org/mozilla-central/rev/4303f3ec286a
https://hg.mozilla.org/mozilla-central/rev/f7ffff73891a