1783622 - Recover all MMathFunctions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

• Add recover support for the remaining MMathFunction types.
• And then perform some clean-ups in "jsmath.cpp" and "Recover.cpp".

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 1: Recover all MMathFunction functions. r=iain!

Use the existing math_Func_impl functions instead of creating another set of
duplicates. This also makes it clearer that these functions can't fail.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 2: Remove Handle versions of Math functions. r=iain!

These were only used during recovering. If we take the same approach as in
part 1 and directly call the math_Func_impl functions, we can remove the
Handle overloads.

Depends on D153925

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 3: Avoid unnecessary rooting during recovering. r=iain!

Copy-pasta has resulted in lots of unnecessary rooting.

Depends on D153926

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 4: Make math functions file static where possible. r=iain!

These functions are only used in "jsmath.cpp", so we should declare them as static.

Depends on D153927

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 5: Merge both math_function functions. r=iain!

The second version is no longer needed after part 2.

Depends on D153928

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 6: Check asm.js builtin functions using InlinableNative. r=iain!

This matches how we detect Math built-ins in CacheIR and is needed for the
next part of this patch series.

Depends on D153929

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1783622 - Part 7: Make more math functions file static. r=iain!

We can now declare these functions as static, too.

Depends on D153930

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1178346c9087
Part 1: Recover all MMathFunction functions. r=iain
https://hg.mozilla.org/integration/autoland/rev/870ff83154d8
Part 2: Remove Handle versions of Math functions. r=iain
https://hg.mozilla.org/integration/autoland/rev/1c479d82b90b
Part 3: Avoid unnecessary rooting during recovering. r=iain
https://hg.mozilla.org/integration/autoland/rev/9d924fbed36d
Part 4: Make math functions file static where possible. r=iain
https://hg.mozilla.org/integration/autoland/rev/cb9dcd48333e
Part 5: Merge both math_function functions. r=iain
https://hg.mozilla.org/integration/autoland/rev/263b4752d739
Part 6: Check asm.js builtin functions using InlinableNative. r=iain
https://hg.mozilla.org/integration/autoland/rev/25490ca6fc81
Part 7: Make more math functions file static. r=iain

Comment 9

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/1178346c9087
https://hg.mozilla.org/mozilla-central/rev/870ff83154d8
https://hg.mozilla.org/mozilla-central/rev/1c479d82b90b
https://hg.mozilla.org/mozilla-central/rev/9d924fbed36d
https://hg.mozilla.org/mozilla-central/rev/cb9dcd48333e
https://hg.mozilla.org/mozilla-central/rev/263b4752d739
https://hg.mozilla.org/mozilla-central/rev/25490ca6fc81