1783641 - Deleting a word doesn't eliminate the space around it

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Edgar Chen [:edgar]]

(filed from https://bugzilla.mozilla.org/show_bug.cgi?id=1779913#c7)

STR:

1. Write "one two".
2. Double click the word "one", then press delete.

Actual result:
The space between the words is not deleted in Firefox

Expected result:
Chrome and Safari deletes the space between the words.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

On Mac, when I double click the word "one", the space between "one" and "two" isn't selected.
One Win11, the space is selected.

Hi Jan, would you like to take a look to see what's up in our code? Thanks.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

If HTMLEditor extends the deleting range, it will need to manage InputEvent.getTargetRange() result too. Or the other browsers could be that they just forget to convert the white-space to NBSP. Investigate how they work for these things.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

And also check the case white-space:pre.

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1783641: Deleting a selected word deletes surrounding whitespace on MacOS. r=masayuki

This is a WIP commit, currently only contains a test to reproduce the issue.

Comment 5

[Edgar Chen [:edgar]]

I tested comment #0 on Linux, Chrome doesn't deletes the space between the words.

Comment 6

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1783641: Deleting a selected word deletes surrounding whitespace on MacOS. r=masayuki

Native behaviour on MacOS dictates one whitespace being removed after double-clicking a word and pressing delete.
This behaviour is achieved by saving the information that the selection is created by doubleclick to the nsFrameSelection
and using it in the DeleteRangeTransaction, where the range is extended by one whitespace character before or after the range.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdbed5920aeb
Deleting a selected word deletes surrounding whitespace on MacOS. r=masayuki

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bdbed5920aeb