1783643 - Don't open downloads panel for very first drag-and-drop download in a new profile

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[:Gijs (he/him)]

See discussion in bug 1782205 for the context and confusion this is causing.

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1783643 - Don't open downloads panel if window is inactive. r=Gijs

Since bug 1741076, the downloads panel is already configured not to show
the downloads panel if the top chrome window is inactive. However, this
check doesn't matter if the downloads panel has never been opened before
in the profile (represented by pref browser.download.panel.shown). This
patch changes the check so that if the top window is not active, we
don't show the panel, no matter what.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b00df0190ccc
Don't open downloads panel if window is inactive. r=Gijs

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b00df0190ccc

Comment 4

[Shane Hughes [:aminomancer]]

👍 Thanks

Comment 5

[Shane Hughes [:aminomancer]]

Hi Ryan, do you want to uplift this one to esr102 as well?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I'm on board with taking whatever QoL improvements and papercut fixes we feel are important to take before ESR users see these changes for the first time.

Comment 7

[Shane Hughes [:aminomancer]]

Comment on attachment 9288792 [details]
Bug 1783643 - Don't open downloads panel if window is inactive. r=Gijs

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Since Fx98, the downloads panel is supposed to open automatically when starting a download, but not if the window is not active/focused. This is because of an issue on Linux where a panel, opened within a window that's underneath another window, can appear on top of the topmost window. But prior to this patch, there was a bug where, the first time the panel is opened, it opened even if the window was not focused.
• User impact if declined: ESR102 users will encounter the bug this patch was intended to fix
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are very minimal and only affect one method that determines whether the downloads panel will open or not.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288792 [details]
Bug 1783643 - Don't open downloads panel if window is inactive. r=Gijs

Approved for 102.3esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/c70029162229