1783644 - Quick Actions elements are displayed for non-general search engines shortcuts

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea]]

Attachment: Amazon search shortcut

Note

• The entire set of Quick Action buttons should only be displayed for Actions search shortcut

Found in

• 105.0a1 2022-08-07

Affected versions

• latest Nightly 105.0a1 2022-08-07

Affected platforms

• Win 10 64-bit

Steps to reproduce

1. Focus address bar and select any non-general search engine icon (Wikipedia, eBay, Amazon) from This time search with section
2. Search shortcut mode opens for the selected engine
3. Clear the address bar then type @ama and select the result ("Search with Amazon.com") with mouse click or by pressing Right Arrow after @amazon autofill
4. While Amazon search mode is opened, type Inspector or any other keyword that would activate Quick Action items

Expected result

• Quick Action items are not displayed for non-general search engines

Actual result

• Quick Action items are shown for Amazon, eBay and Wikipedia search shortcuts

Regression range

• Not a regression, I also reproduced on older Nightly where QuickActions were pref'd off

Comment 1

[Petruta Horea [:phorea]]

Attachment: open search engine

This is also reproducible with Open Search Engines.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1783644 - Dont show QuickActions in other search modes. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a4f57a088e8
Dont show QuickActions in other search modes. r=adw

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4a4f57a088e8

Comment 5

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 105.0b1 and 106.0a1 (2022-08-23) on Windows 10, Mac 11 and Ubuntu 22:

• 0 prefix (empty search mode) does not display any quick actions (excluding actions search mode)
• keyword search mode does not display the quick action (excluding actions search mode)

Comment 6

[Adrian Florinescu [:aflorinescu]]

Dale, I just want to confirm that we did the right thing here and it's actually desired not to show quickactions in search modes.

AIUI and pro the current approach, it's more likely to use the keyword + address bar which defaults default search engine to get to a quick action, but unlikely to want a quickaction when I'm entering a search mode, the extra click pointing that I'd like a search result.

Comment 7

[Dale Harvey (:daleharvey)]

Yes the only search mode we want to show actions in is the actions search mode, the user has indicated they want results from that particular provider so its confusing to have them, if the user wants quickactions then they dont go in to the mode so I dont think we lose anything not having them displayed