1783664 - Add a helper method to construct a rejected Promise

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

There are multiple lines in dom/streams that creates a rejected promise, e.g. https://searchfox.org/mozilla-central/rev/5644fae86d5122519a0e34ee03117c88c6ed9b47/dom/streams/ReadableStream.cpp#371-377.

RefPtr<Promise> promise = Promise::Create(aStream->GetParentObject(), aRv);
if (aRv.Failed()) {
  return nullptr;
}
JS::Rooted<JS::Value> storedError(aCx, aStream->StoredError());
promise->MaybeReject(storedError);
return promise.forget();

A helper function can reduce this to:

JS::Rooted<JS::Value> storedError(aCx, aStream->StoredError());
return Promise::CreateRejected(storedError, aRv);

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1783664 - Add Promise::CreateRejected r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1587d55f66d
Add Promise::CreateRejected r=smaug

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1587d55f66d