No need to store HTML references in search graph if in default/simple mode

RESOLVED FIXED

Status

SeaMonkey
Search
RESOLVED FIXED
15 years ago
9 years ago

People

(Reporter: Robert John Churchill, Assigned: Robert John Churchill)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.39 KB, patch
Samir Gehani
: review+
jag (Peter Annema)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
No need to store HTML references in search graph if in default/simple mode as
HTML chunks aren't displayed in UI. This will significantly reduce memory
footprint for storing search results.
(Assignee)

Comment 1

15 years ago
Created attachment 105139 [details] [diff] [review]
Patch

Samir, care to review?
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED

Comment 2

15 years ago
Comment on attachment 105139 [details] [diff] [review]
Patch

r=sgehani
Attachment #105139 - Flags: review+

Comment 3

15 years ago
Comment on attachment 105139 [details] [diff] [review]
Patch

>Index: mozilla/xpfe/components/search/src/nsInternetSearchService.h
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/components/search/src/nsInternetSearchService.h,v
>retrieving revision 1.15
>diff -i -u -4 -r1.15 nsInternetSearchService.h
>--- mozilla/xpfe/components/search/src/nsInternetSearchService.h	19 Jun 2002 00:50:20 -0000	1.15
>+++ mozilla/xpfe/components/search/src/nsInternetSearchService.h	5 Nov 2002 01:17:04 -0000
>@@ -60,8 +60,9 @@
>                                  public nsSupportsWeakReference
> {
> private:
>   static PRInt32          gRefCnt;
>+  static PRInt32          mBrowserSearchMode;
>   static PRBool           mEngineListBuilt;

These should be g*, not m*.

You may also want to initialize gBrowserSearchMode (and perhaps
gEngineListBuilt?).

sr=jag with that changed.
Attachment #105139 - Flags: superreview+
(Assignee)

Comment 4

15 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.