Closed Bug 1783683 Opened 2 years ago Closed 2 years ago

Keep early hint preload on same-origin redirect

Categories

(Core :: Networking: HTTP, defect, P2)

defect

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: manuel, Assigned: mleclair)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

We currently cancel all preloads on error/redirects: https://searchfox.org/mozilla-central/rev/5644fae86d5122519a0e34ee03117c88c6ed9b47/netwerk/protocol/http/EarlyHintsService.cpp#59

The spec says, that only cross-origin should get cancelled and same origin redirects should be kept. There is no mention of cancelling preloads of 4xx/5xx pages?:

Only the first early hint response served during the navigation is handled, and it is discarded if it is succeeded by a cross-origin redirect. [2]

So we should shouldn't cancel early hints on same origin redirects. Dragana, is it correct, that we also want to keep the preloads on error pages or should this bug only be about same origin redirects?

Flags: needinfo?(dd.mozilla)
Blocks: 1783686

We should do both. You can open separate bugs for the second issue.

Flags: needinfo?(dd.mozilla)
See Also: → 1783848
Summary: Keep early hint preload on same-origin redirect/error pages → Keep early hint preload on same-origin redirect
Assignee: nobody → mleclair
Pushed by mleclair@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e632abd052f6
Cancel early hints if origin isn't the same r=kershaw,necko-reviewers
Regressions: 1798716
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: