Closed Bug 1783688 Opened 2 years ago Closed 2 years ago

Print Quick Actions should be available on every page

Categories

(Firefox :: Address Bar, defect)

Firefox 105
defect

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 --- disabled
firefox106 --- verified

People

(Reporter: phorea, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Note

  • Inspector, View Source and Print are generally available on about: pages so that should remain valid for Quick Actions as well

Found in

  • 105.0a1 2022-08-07

Affected versions

  • latest Nightly 105.0a1 2022-08-07

Affected platforms

  • Win 10 64-bit

Steps to reproduce

  1. Open a new tab, focus the address bar and select the Actions shortcut
  2. Check all the Quick Actions buttons
  3. Repeat on about:config, about:preferences, etc.

Expected result

  • Inspector, View Source and Print buttons are enabled all the time. There is no case in which these should be disabled.

Actual result

  • Inspector, View Source and Print buttons are disabled on about: pages

Regression range

  • Not a regression, I also reproduced on 2022-07-28 Nightly where these Actions landed

(In reply to Petruta Horea [:phorea] from comment #0)

Steps to reproduce

  1. Open a new tab, focus the address bar and select the Actions shortcut

Note: the "Open Inspector" button (which is affected by this bug) is shown by default on the dropdown panel; no need to select-the-actions-shortcut to see this bug on that one.

See screenshot in my dupe bug 1783759: attachment 9288921 [details] which just shows the dropdown panel that appears when you focus the address bar on a new tab.

(In reply to Daniel Holbert [:dholbert] from comment #2)

Note: the "Open Inspector" button (which is affected by this bug) is shown by default on the dropdown panel; no need to select-the-actions-shortcut to see this bug on that one.

The main actions (and their number) are subject to change in near future.

Thank you for testing!

Has STR: --- → yes
Summary: Open Inspector, View Source and Print Quick Actions should be available on about: pages → Open Inspector, View Source and Print Quick Actions should be available on every page
No longer blocks: 1778132
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

As we are fixing also the active/inactive for Inspector and View Source action in bug 1783877, in this bug, we fix only Print action.

Depends on D155333

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c51f76b5f212
Make print action enable on every page. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)

Verified the fix on Ubuntu 22, Mac 11 and Windows 10 using 106.0a1 (2022-08-28):

  • about:pages with print quickaction
  • home page with print quickaction
  • view source with print quickaction

Let's also update the title to reflect the fix landed here.

Status: RESOLVED → VERIFIED
Summary: Open Inspector, View Source and Print Quick Actions should be available on every page → Print Quick Actions should be available on every page
No longer blocks: 1838617
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: