1783689 - TypeError: warning() takes 2 positional arguments but 3 were given

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

https://searchfox.org/mozilla-central/rev/5644fae86d5122519a0e34ee03117c88c6ed9b47/testing/mozharness/mozharness/base/python.py#355 has a typo, which intermittently results in

https://treeherder.mozilla.org/logviewer?job_id=385978217&repo=mozilla-central&lineNumber=438

[task 2022-08-01T07:01:35.798Z] 07:01:35  WARNING - Unable to start resource monitor: Traceback (most recent call last):
[task 2022-08-01T07:01:35.798Z] 07:01:35  WARNING -   File "Z:\task_1659335171\mozharness\mozharness\base\script.py", line 2292, in run_action
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -     self._possibly_run_method(method_name, error_if_missing=True)
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -   File "Z:\task_1659335171\mozharness\mozharness\base\script.py", line 2244, in _possibly_run_method
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -     return getattr(self, method_name)()
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -   File "Z:\task_1659335171\mozharness\mozharness\base\python.py", line 567, in create_virtualenv
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -     global_options=global_options,
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -   File "Z:\task_1659335171\mozharness\mozharness\base\python.py", line 357, in install_module
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING -     ", but max retries reached. continuing...",
[task 2022-08-01T07:01:35.799Z] 07:01:35  WARNING - TypeError: warning() takes 2 positional arguments but 3 were given

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: Bug 1783689 - Fix typo in mozharness warning; r=

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d404154a98f1
Fix typo in mozharness warning; r=releng-reviewers,aki

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d404154a98f1

Comment 4

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9288852 [details]
Bug 1783689 - Fix typo in mozharness warning; r=

test harness fix

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9288852 [details]
Bug 1783689 - Fix typo in mozharness warning; r=

Approved for 102.14esr

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr102/rev/bdc2ebf043cf