1783712 - [wpt-sync] Sync PR 35382 - [wpt] Fix break-request tests.

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35382 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35382
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[wpt] Fix break-request tests.

These tests were presumably written when the flex spec said something
along the lines of:
"when a forced break (via. page-break-before/page-break-after) is
encounted, create a new flex-line".

The spec in this state was overloading the fragmentation properties to
control breaking of flex-lines, and was subsequently updated to refer
to forced breaks when fragmentation was invovled.

These tests don't have any fragmentation involved, and are asserting
incorrect behaviour that breaks should be inserted.

(There is an argument that an additional property/properties should be
introduced to allow for this - but that is a separate issue).

Updated tests to assert to behaviour change in the presence of
page-break-before/page-break-after.

Change-Id: Id3575b5b17173681600ed63cd40c8bb87281113b

Reviewed-on: https://chromium-review.googlesource.com/3813703
WPT-Export-Revision: 682416b13fa5e3299c5dde332138f8c6422e27db

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=01eac39209a2b976e38c7d8db6c5d2e8c7164b1d

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d27b7adc2a30
[wpt PR 35382] - [wpt] Fix break-request tests., a=testonly
https://hg.mozilla.org/integration/autoland/rev/5ebf431621bc
[wpt PR 35382] - Update wpt metadata, a=testonly

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/d27b7adc2a30
https://hg.mozilla.org/mozilla-central/rev/5ebf431621bc