1783750 - MR onboarding colorway screen should save colorway on click of primary CTA

Status: VERIFIED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Punam Dahiya [:pdahiya]]

Current theme selection and colorway screen in bug 1774066 , applies theme on click of theme icon. Scope of this bug is to guard exit points such as tab closing, ESC so that if a user exits without clicking primary CTA 'Set colorway' on both new and existing onboarding screen , user previous theme/colorway choice gets applied

Comment 1

[Punam Dahiya [:pdahiya]]

NI @mardak to help provide direction on how to best handle exit points such as tab closing and ESC for dialog modal

Comment 2

[Ed Lee :Mardak]

Bug 1697222 originally implemented this with a pagehide event listener that would revert the theme to the previous one. This cleanup behavior would be disabled when saving the theme/colorway. So we could add some special behavior to the Colorways component that knows how to save the previous theme and ignores it / removes the pagehide listener when moving to the next screen.

Comment 3

[Jason Prickett]

Attachment: Bug 1783750 - MR Onboarding Colorways save colorway on primary cta click r?mardak,pdahiya

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a1c540eac4
MR Onboarding Colorways save colorway on primary cta click r=pdahiya

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing newtab failures

• backout: https://hg.mozilla.org/integration/autoland/rev/8e57fab1c5e5e4b2658b909ada847d0bd89a9e86
• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FUgEqin2SIOQonCtYuvwcg.0&revision=a9a1c540eac4375e0b641a58bd89a3ba0ff6eb6b
• failure log: https://treeherder.mozilla.org/logviewer?job_id=388634751&repo=autoland&lineNumber=98

[task 2022-08-26T23:16:14.343Z] npm WARN deprecated core-js@2.6.11: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
[task 2022-08-26T23:16:14.709Z] 
[task 2022-08-26T23:16:14.709Z] added 766 packages, and audited 767 packages in 26s
[task 2022-08-26T23:16:14.709Z] 
[task 2022-08-26T23:16:14.709Z] 91 packages are looking for funding
[task 2022-08-26T23:16:14.709Z]   run `npm fund` for details
[task 2022-08-26T23:16:14.740Z] 
[task 2022-08-26T23:16:14.740Z] 25 vulnerabilities (11 moderate, 12 high, 2 critical)
[task 2022-08-26T23:16:14.740Z] 
[task 2022-08-26T23:16:14.740Z] To address issues that do not require attention, run:
[task 2022-08-26T23:16:14.740Z]   npm audit fix
[task 2022-08-26T23:16:14.740Z] 
[task 2022-08-26T23:16:14.740Z] To address all issues possible (including breaking changes), run:
[task 2022-08-26T23:16:14.740Z]   npm audit fix --force
[task 2022-08-26T23:16:14.740Z] 
[task 2022-08-26T23:16:14.740Z] Some issues need review, and may require choosing
[task 2022-08-26T23:16:14.741Z] a different dependency.
[task 2022-08-26T23:16:14.741Z] 
[task 2022-08-26T23:16:14.741Z] Run `npm audit` for details.
[task 2022-08-26T23:16:14.777Z] + node bin/try-runner.js
[task 2022-08-26T23:16:14.814Z] TEST START | checkBundles
[task 2022-08-26T23:16:23.204Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2022-08-26T23:16:23.204Z]   npx browserslist@latest --update-db
[task 2022-08-26T23:16:23.204Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2022-08-26T23:16:23.204Z] Browserslist: caniuse-lite is outdated. Please run:
[task 2022-08-26T23:16:23.204Z]   npx browserslist@latest --update-db
[task 2022-08-26T23:16:23.204Z]   Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
[task 2022-08-26T23:16:23.209Z] TEST-UNEXPECTED-FAIL checkBundles | About:welcome bundle out of date
[task 2022-08-26T23:16:23.211Z] { checkBundles: false }
[task 2022-08-26T23:16:23.211Z] CODE 1
[taskcluster 2022-08-26 23:16:23.676Z] === Task Finished ===
[taskcluster 2022-08-26 23:16:23.677Z] Unsuccessful task run with exit code: 1 completed in 147.033 seconds

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a106238a536
MR Onboarding Colorways save colorway on primary cta click r=pdahiya

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8a106238a536

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8a106238a536

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm the following:

• The applied theme is successfully saved if the "Set colorway" button is clicked.
• The theme is NOT saved if the "Skip this step" button from the "Colorway" screen of the "about:welcome" page is clicked.
• The theme is NOT saved if the "Skip this step" button from the "Colorway" modal for existing users is clicked.
• The theme is NOT saved if the "Skip this step" button from the "Colorway" modal for existing users is dismissed using the "Esc" key.

Verified using the latest Firefox Nightly (106.0a1 Build ID - 20220828210513) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.