1783770 - Miscellaneous start-up performance improvements

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Geoff Lankow (:darktrojan)]

I've got a number of patches for improving start-up performance. I don't think it's worth filing a bug for each so I'll stick them all in one bug, this one.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Stop loading mail notification modules at profile-after-change. r=mkmelin

These two modules are loaded at profile-after-change to add some listeners/observers. AFAICT, none of the things they are listening for will happen this early, so we can initialise them later.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Start the chat logger after the first window loads. r=freaktechnik

By delaying the start of the chat logger, we can prevent a number of modules from loading before the first window does.

Depends on D154026

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Convert some module imports to lazy imports. r=#thunderbird-reviewers

These modules don't need to be loaded with the module that imports them. Some don't need loading at all.

Depends on D154027

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Delay starting Gloda IM indexing until after the first window loads. r=freaktechnik

I see no reason for this to start so early. Making this change plus some others means we can avoid loading all of the Gloda code until much later. Plus if chat is disabled we can avoid it altogether.

Depends on D154028

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Move Gloda constants to a separate module, part 1. r=#thunderbird-reviewers

Depends on D154029

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Move Gloda constants to a separate module, part 2. r=#thunderbird-reviewers

Depends on D154030

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1783770 - Move Gloda constants to a separate module, part 3. r=#thunderbird-reviewers

Depends on D154031

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17ad6ea84651
Stop loading mail notification modules at profile-after-change. r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fdf6a586175e
Start the chat logger after the first window loads. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/8215c04fbfe3
Convert some module imports to lazy imports. r=mkmelin
https://hg.mozilla.org/comm-central/rev/52e1ef6ec3f3
Delay starting Gloda IM indexing until after the first window loads. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/d8166ba9e8b9
Move Gloda constants to a separate module, part 1. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e697b1403810
Move Gloda constants to a separate module, part 2. r=mkmelin
https://hg.mozilla.org/comm-central/rev/cbeeafe798f3
Move Gloda constants to a separate module, part 3. r=mkmelin

Comment 10

[Geoff Lankow (:darktrojan)]

That's enough for now. I have some other things in mind but they can have another bug.