Update image icon used for default theme in MR onboarding colorway screen
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox105 | --- | verified |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Scope of this bug is to update icon used for default theme
Assignee | ||
Comment 1•2 years ago
|
||
Ni Ania to help with icon used in default theme svg on colorway screen
Assignee | ||
Updated•2 years ago
|
Hi Punam,
Apologies for the delay with this, here's the icon.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42ba742c1218 Update image icon used for default theme in MR onboarding colorway screen r=mviar
Comment 5•2 years ago
|
||
bugherder |
Comment 6•2 years ago
|
||
I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220818214910) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.
- The default theme icon is updated with the attached asset.
However, during verification, I observed that the colorway icons from Figma have a more pronounced color than in the current implementation. @Punam, is this difference expected?
Assignee | ||
Comment 7•2 years ago
|
||
Thanks @srosu that's expected as colorways closet uses icon available with respective colorways e.g. resource://builtin-themes/colorways/2022playmaker/balanced/icon.svg . Left comment in figma for UX to confirm that's expected behavior
https://www.figma.com/file/2TrMkNefxzhMCXjUqM8KIy?node-id=4854:116803#252469886
Comment 8•2 years ago
|
||
Thanks, Punam! I'm marking this enhancement as Verified based on comments 6 and 7.
Comment 9•2 years ago
|
||
Thanks for flagging this Punam! Yep, I'm expecting it to appear as it does in the Colorways modal. I stole these designs from Victoria's figma file but they may be outdated/not represent the actual implementation.
Description
•