Closed Bug 1783780 Opened 2 years ago Closed 2 years ago

Update image icon used for default theme in MR onboarding colorway screen

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
105 Branch
Iteration:
105.2 - Aug 8 - Aug 19
Tracking Status
firefox105 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Scope of this bug is to update icon used for default theme

Ni Ania to help with icon used in default theme svg on colorway screen

Flags: needinfo?(asafko)
Iteration: --- → 105.2 - Aug 8 - Aug 19
Priority: -- → P1
Attached image Default.svg

Hi Punam,
Apologies for the delay with this, here's the icon.

Flags: needinfo?(asafko)
Assignee: nobody → pdahiya
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42ba742c1218
Update image icon used for default theme in MR onboarding colorway screen r=mviar
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220818214910) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.

  • The default theme icon is updated with the attached asset.

However, during verification, I observed that the colorway icons from Figma have a more pronounced color than in the current implementation. @Punam, is this difference expected?

Flags: needinfo?(pdahiya)

Thanks @srosu that's expected as colorways closet uses icon available with respective colorways e.g. resource://builtin-themes/colorways/2022playmaker/balanced/icon.svg . Left comment in figma for UX to confirm that's expected behavior

https://www.figma.com/file/2TrMkNefxzhMCXjUqM8KIy?node-id=4854:116803#252469886

Flags: needinfo?(pdahiya)

Thanks, Punam! I'm marking this enhancement as Verified based on comments 6 and 7.

Status: RESOLVED → VERIFIED

Thanks for flagging this Punam! Yep, I'm expecting it to appear as it does in the Colorways modal. I stole these designs from Victoria's figma file but they may be outdated/not represent the actual implementation.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: