1783811 - "Move Tab" and "Open in New Container Tab" options should be disabled for the Firefox View tab (and hidden tabs in general) in the "List all tabs" menu

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: ListAllTabs_FirefoxView.png

Affected versions

• Nightly 105.0a1 ( 0220808214423)

Affected platforms

• Windows 10x64
• Ubuntu 18.4
• macOS 10.13

Steps to reproduce

1. Launch Firefox with browser.tabs.firefox-view=true
2. Click on the List All tabs menu
3. Go to Hidden Tabs
4. Right click on Firefox View
5. Click Move to Start/Move to End/Mute tab

Expected result

• Firefox View tab should not have the Move to Start, End/ Mute options enabled in List All tabs menu

Actual result

• No action seen when clicking the Move to Start/End options inside the Hidden Tabs menu
• The Firefox View tab has mute option enabled

Regression range
New feature

Comment 1

[Dão Gottwald [:dao]]

There's a couple of context menu items I think we didn't necessarily want to expose for the Firefox View tab, but I think the "Move Tab" options and "Open in New Container Tab" are particularly confusing and don't make a whole lot of sense for hidden tabs, for which I think we should disable those. "Mute Tab" I think we want to keep because hidden tabs can play sound, and I don't think we should treat the Firefox View tab in some special way there.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1783811 - "Move Tab" and "Open in New Container Tab" options should be disabled for the Firefox View tab (and hidden tabs in general) in the "List all tabs" menu. r=Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ccb1a4de29
"Move Tab" and "Open in New Container Tab" options should be disabled for the Firefox View tab (and hidden tabs in general) in the "List all tabs" menu. r=Gijs

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/19ccb1a4de29

Comment 5

[Bogdan Maris, Desktop QA]

I verified that the options Move Tab and Open in New container tab are disabled for the hidden tabs using latest Nightly 107.0a1 and Firefox 106.0b8 (only Move Tab) across platforms (Windows 10, macOS 11 and Ubuntu 22.04).