Closed Bug 1783813 Opened 3 years ago Closed 3 years ago

Unify debugger initialization and thread selection

Categories

(DevTools :: Debugger, enhancement)

enhancement

Tracking

(firefox105 fixed)

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

We are currently updating more things when selecting a thread than when opening the debugger.
Let's use a unique codepath when it comes to handle a new top level target.

When we select a thread we do all this:
https://searchfox.org/mozilla-central/rev/c0bed29d643393af6ebe77aa31455f283f169202/devtools/client/debugger/src/actions/pause/commands.js#20-51
While we do only this when opening the debugger:
https://searchfox.org/mozilla-central/rev/c0bed29d643393af6ebe77aa31455f283f169202/devtools/client/debugger/src/actions/navigation.js#38-48

Also in the reducer we have two distinct action which should ideally have the same behavior, but this isn't guaranteed as they have distinct implementation:
https://searchfox.org/mozilla-central/rev/c0bed29d643393af6ebe77aa31455f283f169202/devtools/client/debugger/src/reducers/pause.js#236-242

We are updating more things when selecting a thread than when opening the debugger.
Let's use a unique codepath when it comes to handle a new top level target.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a188205b2cb [devtools] Unify debugger initialization and thread selection. r=bomsy
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: