1783881 - Quick actions search mode should filter quick actions

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Adrian Florinescu [:aflorinescu]]

Note

• Address bar input match and quick actions search mode should have different functions, in which under search mode, as an user, I would expect the filtering to happen after keywords + labels.

Found in

• 105.0a1 (2022-08-09)

Affected versions

• 105.0a1 (2022-08-09)

Affected platforms

• Windows 10

Steps to reproduce

1. Open Firefox. (quick actions enabled - default in Nightly 105)
2. Focus address and enable quickactions search mode.
3. type View
4. type Window

Expected result

3. The quick actions should be filtered, displaying the ones containing "view", even though view would not hit atm as a cmd-keyword
4. Open Private Browsing Window is displayed.

Actual result

3. View source quick action is displayed.
4. Nothing is displayed.

Regression range

• N/A - new feature

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1783881 - Add label to commands so QuickActions are filtered. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c0545383859
Add label to commands so QuickActions are filtered. r=adw

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing Xpcshell failures. CLOSED TREE
Backout link
Push with failures
Link to failure log 1
Link to failure log 2
Link to failure log 3
Failure line :
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest_bestMatch.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_autofill_functional.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/quicksuggest/unit/test_quicksuggest_merino.js | xpcshell return code: 0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/144354a52649
Add label to commands so QuickActions are filtered. r=adw

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/144354a52649

Comment 6

[Dale Harvey (:daleharvey)]

I got a green try run but the rebase introduced a failure, fixed and landed

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx106.0a1 on Windows 10 and Ubuntu 22. Quickaction search mode can be correctly filtered based on user input.