1783882 - Search Bar search suggestions cannot be shown when many search engines are installed

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Fanolian]

Attachment: Searchbar suggestions STR.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0
Build ID: 20220809093338

Steps to reproduce (please refer to the attached video)

1. In a new profile, add search bar to the toolbar.
2. Install at least 16 search engines. You can install them all from one site at https://mycroftproject.com/dlstats.html.
3. Using the default Google Search search engine, type a word in search bar. Wait for the suggestions to appear.
4. Narrow search bar until the search engine selection area spans across at least 6 rows.

(Step 3 and 4 can be swapped.)

Actual result

The search suggestions area is not tall enough to show any suggestions.

Expected result

Search bar dropdown should consider the case of having many search engines installed (I have 33 engines in 7 rows in my main profile). Search suggestions area should not shrink (that much).

Workaround

Increase the width of search bar.

Regression

Last good Nightly: 2022-08-07
First bad Nightly: 2022-08-08
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=328d2ccc6eb9f50967f8c6cb84540d874c2f9f25&tochange=fe257e8499eace65aad64e50267ed97a8f9a434f

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=523ef50a4e16f63a16a6f00e29420f324d413299&tochange=3861f44270a2d52e1d65e0b4b6c6be22f020fc40

It should be regressed by bug 1776417.

Comment 1

[Fanolian]

Attachment: Search suggestions bug.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1776417

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1783882 - Don't flex searchbar listbox. r=mak,dao

I can't reproduce this on Linux (which would make it easier to dig into what's
going on), but I confirmed this fixes the issue on Windows.

The flexing algorithm of XUL doesn't deal well with the footer block.

This shouldn't be needed, I think, because the listbox height is handled
explicitly in

https://searchfox.org/mozilla-central/rev/6a37a2ab9328bec6a29f688d1b2fba6974d34905/toolkit/content/widgets/autocomplete-popup.js#361

Comment 4

[Emilio Cobos Álvarez (:emilio)]

So the attached patch fixes it, but I realized that it wouldn't quite deal with a panel that doesn't fit on the screen. Unlikely, but can happen. I'll file a bug to take a more robust approach to this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11009a10b69e
Don't flex searchbar listbox. r=dao

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/11009a10b69e

Comment 7

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce this issue using the STR from Comment 0 on an affected Nightly build 105.0a1 (20220809093338), Windows 10 x64.
Verified as fixed on latest Nightly 105.0a1 (20220817190533).