1783915 - ShadowRealm wrapped functions don't correctly toString.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

sr = new ShadowRealm();
p = sr.evaluate(`var resolve;
 new Promise((r,_) => { resolve = r;}).then(
    (r) => { console.log("Resolved with"); }
    ); resolve`)

Produces TypeError: Function.prototype.toString called on incompatible object in SpiderMonkey, but works correctly in Safari Technology Preview.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Interesting, it's actually the shell complaining while trying to print p that's the issue here.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Minimal example: new ShadowRealm().evaluate("function f() { }; f").toString();

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1783915 - Provide a ToStringOp for WrappedFunctionObjects to avoid JSFunction brand-check exception r?bthrall

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87213cd29f42
Provide a ToStringOp for WrappedFunctionObjects to avoid JSFunction brand-check exception r=bthrall

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/87213cd29f42