1783957 - Crash in [@ mozilla::dom::AutoJSAPI::Init | mozilla::ClientWebGLContext::JsWarning]

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/12b5c55d-7a99-4ef2-8b80-11ae80220803

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so mozilla::dom::AutoJSAPI::Init dom/script/ScriptSettings.cpp:426
1 libxul.so mozilla::ClientWebGLContext::JsWarning const dom/canvas/ClientWebGLContext.cpp:143
2 libxul.so mozilla::ClientWebGLContext::OnContextLoss const dom/canvas/ClientWebGLContext.cpp:204
3 libxul.so mozilla::HostWebGLContext::OnContextLoss dom/canvas/HostWebGLContext.cpp:80
4 libxul.so mozilla::WebGLContext::LoseLruContextIfLimitExceeded dom/canvas/WebGLContext.cpp:750
5 libxul.so mozilla::WebGLContext::Create dom/canvas/WebGLContext.cpp:612
6 libxul.so mozilla::HostWebGLContext::Create dom/canvas/HostWebGLContext.cpp:58
7 libxul.so mozilla::dom::WebGLParent::RecvInitialize dom/canvas/WebGLParent.cpp:18
8 libxul.so mozilla::dom::PWebGLParent::OnMessageReceived ipc/ipdl/PWebGLParent.cpp:367
9 libxul.so mozilla::gfx::PCanvasManagerParent::OnMessageReceived ipc/ipdl/PCanvasManagerParent.cpp:377

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1783957 - Part 1. Fix up thread annotations for WebGLContext's LRU position.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1783957 - Part 2. Ensure we can manage LRU WebGL contexts on different threads.

On Android, we can have GL contexts in the content process. On Linux, we
have crash report evidence of GL contexts in the compositor (parent)
process. This is problematic because when we want to lose the LRU WebGL
context, we need to be on its owning thread in order to do so.

This patch adds the necessary dispatching for any WebGL context owned by
an arbitrary thread to lose another WebGL context on another arbitrary
thread.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178c55caf7e9
Part 1. Fix up thread annotations for WebGLContext's LRU position. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/b0fdc25e2b1a
Part 2. Ensure we can manage LRU WebGL contexts on different threads. r=jgilbert

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/178c55caf7e9
https://hg.mozilla.org/mozilla-central/rev/b0fdc25e2b1a