1784051 - SwCompositor retains shared depth texture for backgrounded tabs on Android

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jamie Nicol [:jnicol]]

The SwCompositor shares a single depth texture for use when rendering to each of its tiles. Each of these may only be a few megabytes of memory. However, on Android each tab has its own compositor, meaning this quickly adds up. We should ensure we deallocate the depth texture when the tab is backgrounded. (perhaps when the last tile/surface is deallocated, once we fix bug 1784049)

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1784051 - Delete SwCompositor's shared depth texture when final surface is destroyed. r?gw

And lazily create it when first surface is created. This prevents us
unnecessarily holding on to that memory when a compositor has no
surfaces, ie when the tab is backgrounded on Android. While each depth
texture may only be a few megabytes, this quickly adds up on Android
where each tab has its own compositor.

Depends on D154635

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20e3e274cc27
Delete SwCompositor's shared depth texture when final surface is destroyed. r=lsalzman

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures with crash:core::panicking::panic_str

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | devtools/client/inspector/rules/test/browser_rules_cubicbezier-commit-on-ENTER.js | application crashed [@ core::panicking::panic_str]

And also: https://treeherder.mozilla.org/logviewer?job_id=387476737&repo=autoland

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75dfb2eca175
Delete SwCompositor's shared depth texture when final surface is destroyed. r=lsalzman

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/75dfb2eca175