1784098 - explore making securityInfo concrete in necko interfaces

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

There are a number of nsISupports securityInfo attributes on various interfaces. To simplify and clarify this attribute and the underlying implementation, we should see if this can be a more concrete type like nsISSLSocketControl.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1784098 - move nsITLSServerConnectionInfo from nsISocketTransport.securityInfo to securityCallbacks r?kershaw

In preparation for making nsISocketTransport.securityInfo a concrete type
(nsITransportSecurityInfo), nsITLSServerConnectionInfo needs to be moved off of
securityInfo. securityCallbacks seems like a reasonable place.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1784098 - make nsISocketTransport.securityInfo explicit as nsISSLSocketControl r?kershaw

Depends on D154256

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1784098 - make nsICacheEntry.securityInfo explicit as nsITransportSecurityInfo r?kershaw

Depends on D154257

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1784098 - remove unused nsISOCKSSocketInfo interface r?kershaw

Depends on D154472

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16ab6547619c
move nsITLSServerConnectionInfo from nsISocketTransport.securityInfo to securityCallbacks r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a2bb8ecd6170
make nsISocketTransport.securityInfo explicit as nsISSLSocketControl r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/a97052238dba
make nsICacheEntry.securityInfo explicit as nsITransportSecurityInfo r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/d22ac7bcb472
remove unused nsISOCKSSocketInfo interface r=kershaw,necko-reviewers

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on nsCOMPtr.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c6c4f26794102b8880ad199c08a6d759f0c987d
Log link: https://treeherder.mozilla.org/logviewer?job_id=388088509&repo=autoland&lineNumber=47852

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d09b784f78d
move nsITLSServerConnectionInfo from nsISocketTransport.securityInfo to securityCallbacks r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/197147c8c1a4
make nsISocketTransport.securityInfo explicit as nsISSLSocketControl r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/8fafb15791c6
make nsICacheEntry.securityInfo explicit as nsITransportSecurityInfo r=kershaw,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/4543051fc51e
remove unused nsISOCKSSocketInfo interface r=kershaw,necko-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9d09b784f78d
https://hg.mozilla.org/mozilla-central/rev/197147c8c1a4
https://hg.mozilla.org/mozilla-central/rev/8fafb15791c6
https://hg.mozilla.org/mozilla-central/rev/4543051fc51e