1784100 - Check for majorRelease2022 nimbus holdback in addition to existing nimbus onboarding features

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Ed Lee :Mardak]

Potentially in addition to bug 1774061's toggling of content with browser.aboutwelcome.templateMR, we'll need to check majorRelease2022 nimbus feature from bug 1783942 to decide whether to show the new content or not (if not then potentially the default content or remote content via aboutwelcome nimbus feature).

https://searchfox.org/mozilla-central/rev/43ba67391e71c57a14420e554e9d381543292611/browser/components/newtab/aboutwelcome/AboutWelcomeChild.jsm#254-255

Similarly the upgrade spotlight should be disabled in the holdback similar to the existing upgradeDialog nimbus feature.

https://searchfox.org/mozilla-central/rev/43ba67391e71c57a14420e554e9d381543292611/browser/components/BrowserGlue.jsm#4370-4372

We can share the same nimbus variable onboarding for both.

Comment 1

[Punam Dahiya [:pdahiya]]

As discussed we need to pass a megaFeature Nimbus variable here to get the desired UI MR vs old onboarding

https://searchfox.org/mozilla-central/rev/d01591796d5faccf762adb09a311d8ee12f7ca7f/browser/components/newtab/aboutwelcome/AboutWelcomeChild.jsm#255

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1784100 - Override aboutwelcome.templateMR feature with majorRelease 2022 r?mardak

Depends on D155885

Comment 3

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1784100 - Override upgradeDialog.enabled feature with majorRelease 2022 r?mardak

Depends on D155886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a42f11d9a1
Override aboutwelcome.templateMR feature with majorRelease 2022 r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/d98aeeed834e
Override upgradeDialog.enabled feature with majorRelease 2022 r=Mardak

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e2a42f11d9a1
https://hg.mozilla.org/mozilla-central/rev/d98aeeed834e