Open Bug 1784125 Opened 3 years ago Updated 1 year ago

Some web site's favicon does not display on the about:newtab page.

Categories

(Firefox :: New Tab Page, defect, P1)

Firefox 103
defect

Tracking

()

People

(Reporter: davidmaxwaterman, Unassigned, NeedInfo)

Details

Attachments

(3 files)

Attached image quora-tile.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.5112.79 Safari/537.36

Steps to reproduce:

  1. open firefox about:newtab
  2. dismiss all the tiles
  3. open another window also on about:newtab
  4. type 'quora.com' into the url bar and hit enter

Actual results:

  1. in the 2nd window, the about:newtab reloads quora.com and you can see the favicon on the tab
  2. in the 1st window showing the original about:newtab, nothing show
  3. if you reload the first window, you get a tile for 'quora' with a fake favicon (in my case, a white 'O' on a pink background

Expected results:

A tile in the 1st about:newtab should have shown immediately the quora.com site loaded, and it should have shown an icon like in the tab.

Attached image quora tab

The Bugbug bot thinks this bug should belong to the 'Firefox::New Tab Page' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → New Tab Page

I'm working on an about:newtab page (not the FF one) and I have
noticed that many sites added to the top sites list don't have
favicons. The reason seems to vary, but this commit is an attempt
to fix the favicon for quora.com.
I'm not 100% sure what the issue is, but it is perhaps because the
page redirect from http://quora.com/ to https://www.quora.com/, and
the SELECT is done in the favicon.sqlite's moz_pages_w_icons table,
and it doesn't get a match since the INSERT is done on the other
URL.
To solve this problem, this patch uses the sqlite fixup_url() on
the page_url parameter when it is INSERT/UPDATE/SELECTed, so the
lookup gets a match - much the same way as the urls stored in the
icon_url of the moz_icons table.

I also have an attempt at notifying the FF about:newtab page about
the new favicon, so that it can update itself, but that is wip. As
such, this patch doesn't really appear to do much, and/or may require
a reload of the about:newtab page to refresh the top sites list.

Also of note:
bug 1781081
https://phabricator.services.mozilla.com/D153650

Assignee: nobody → davidmaxwaterman
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)
Severity: -- → S3
Flags: needinfo?(dharvey)
Priority: -- → P1

The bug assignee is inactive on Bugzilla, and this bug has priority 'P1'.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Assignee: davidmaxwaterman → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(achurchwell)

I'm still here, and could continue working on this.

As you can probably see from phabricator, I did a fix for this, and discussed it with @mossop.

I did the fix while working for Waterfox, and implemented it into another FF fork I was working on for them - I'm reasonably sure that made it into the code base. The fork was for a parent company of Waterfox - I think that's the relationship (not sure), but that relationship has since 'ended' and Waterfox is independent again, iinm. I wanted to push my fix 'upstream' since I'm pretty keen on Mozilla (and FOSS in general) and wanted to contribute.

@mossop's feedback was that another engineer was the expert on this part of the code base and had actually written some suggestions on how to fix the problem I had fix, and it turned out I had actually implemented on of his suggestions, so I was fairly sure it was 'good' so to speak.

However, the upshot of @mossop's review was that it needed some tests added, and my management wasn't keen for me to spend time doing that (wanted me to move onto another project), so I basically shelved it with the intention of working on it when I had a gap in projects or something, but that never came.

Actually, the project I was moved onto was terminated a few months ago (due to events out of my control) and we were all 'let go' and I've been relaxing since then.

I did have a mind to get back to this at some point, and have even set up my personal computer so I can work on it, but I've been enjoying the time off/etc.

Perhaps it is now time to complete it. I've not done tests on the FF code base before, so there is a learning curve.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: