Closed Bug 1784130 Opened 2 years ago Closed 2 years ago

Mobile promo remains after user signs out

Categories

(Firefox :: Firefox View, defect, P1)

Desktop
All
defect
Points:
1

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox105 --- disabled
firefox106 --- verified

People

(Reporter: jberman, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

Actual: User is signed in with no synced mobile device. Receives mobile promo in Fx View. When the user signs out, Fx View returns user to sync flow, but mobile promo remains.

Expected. User is signed in with no synced mobile device. Receives mobile promo in Fx View. When the user signs out, Fx View returns user to sync flow. Mobile promo disappears.

Assignee: nobody → sfoster
Severity: -- → S3
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1
  • Only show the mobile promo when tab syncing is enabled
  • Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
  • Add test coverage for signing out
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4db9e3554d5
Hide mobile promo when signed out. r=niklas
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e099af5543d0
Hide mobile promo when signed out. r=niklas

I was able to reproduce locally, but in the course of investigating and tidying up some of the sandbox restore stuff, the timeouts went away. I'm not convinced that was the root cause, but this try push looks good so Im going to attempt landing again

Flags: needinfo?(sfoster)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Reproduced the initial issue using old Nightly build from 2022-08-10, verified that using latest Firefox 106.0b2 on Windows 11, Ubuntu 20.04 and MacOS 11 the "Get Firefox for mobile" panel is not displayed when disconnecting from an account that has no mobile devices connected to it.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: