Mobile promo remains after user signs out
Categories
(Firefox :: Firefox View, defect, P1)
Tracking
()
People
(Reporter: jberman, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-2022-mr1-firefox-view])
Attachments
(2 files)
Actual: User is signed in with no synced mobile device. Receives mobile promo in Fx View. When the user signs out, Fx View returns user to sync flow, but mobile promo remains.
Expected. User is signed in with no synced mobile device. Receives mobile promo in Fx View. When the user signs out, Fx View returns user to sync flow. Mobile promo disappears.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
- Only show the mobile promo when tab syncing is enabled
- Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
- Add test coverage for signing out
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4db9e3554d5 Hide mobile promo when signed out. r=niklas
Comment 3•2 years ago
|
||
Backed out for causing failures at browser_setup_state.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/88983bb2cc813a185e58deaeecd3dcf831104f5c
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ChDarK7cQ0OtFq81SggQJw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=866131bd45bdf8f58fdc03efe8eccc607befaf85
Failure log: https://treeherder.mozilla.org/logviewer?job_id=388498336&repo=autoland&lineNumber=3133
Pushed by sfoster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e099af5543d0 Hide mobile promo when signed out. r=niklas
Assignee | ||
Comment 5•2 years ago
|
||
I was able to reproduce locally, but in the course of investigating and tidying up some of the sandbox restore stuff, the timeouts went away. I'm not convinced that was the root cause, but this try push looks good so Im going to attempt landing again
Comment 6•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 7•2 years ago
|
||
Reproduced the initial issue using old Nightly build from 2022-08-10, verified that using latest Firefox 106.0b2 on Windows 11, Ubuntu 20.04 and MacOS 11 the "Get Firefox for mobile" panel is not displayed when disconnecting from an account that has no mobile devices connected to it.
Description
•