1784183 - nsWindow::mPanInProgress not initialized

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Timothy Nikkel (:tnikkel)]

This field was

bool mPanInProgress = false;

but then in bug 1748638 got changed to

bool mPanInProgress : 1;

but it did not get init'd in the constructor like the other packed bools.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1784183. Initialize nsWindow::mPanInProgress. r?stransky,emilio,karlt,rmader

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5536ba638ffd
Initialize nsWindow::mPanInProgress. r=rmader

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1748638

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5536ba638ffd

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tnikkel, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9289378 [details]
Bug 1784183. Initialize nsWindow::mPanInProgress. r?stransky,emilio,karlt,rmader

Beta/Release Uplift Approval Request

• User impact if declined: the first touchpad pan in a window on linux may not be handled properly
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just initializing a variable that should have been initialized
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9289378 [details]
Bug 1784183. Initialize nsWindow::mPanInProgress. r?stransky,emilio,karlt,rmader

Approved for 104.0b9

Comment 8

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d56e335c63a9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Pretty minor fix, but also a trivial ride-along fix if you wanted to nominate for ESR102 approval. Feel free to wontfix otherwise.

Comment 10

[Timothy Nikkel (:tnikkel)]

Comment on attachment 9289378 [details]
Bug 1784183. Initialize nsWindow::mPanInProgress. r?stransky,emilio,karlt,rmader

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: very low risk, fixes not initialized variable that would affect only first interaction with a window
• User impact if declined: very low risk, fixes not initialized variable that would affect only first interaction with a window
• Fix Landed on Version: 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): fixes not initialized variable

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9289378 [details]
Bug 1784183. Initialize nsWindow::mPanInProgress. r?stransky,emilio,karlt,rmader

Approved for 102.3esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/6ba85d17ae01