Closed Bug 1784242 Opened 10 months ago Closed 10 months ago

If a Sponsored tile is opened in a new tab using middle click the source has value 0

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 --- verified

People

(Reporter: cmuntean, Assigned: daisuke)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

opening a sponsored tile with middle click.mp4
1.56 MB, video/mp4
Details
Bug 1784242: Make opening in new tab by middle click target for inheritance of sponsored session.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1784242: Make opening in new tab by context menu on tile target for inheritance of sponsored session.
48 bytes, text/x-phabricator-request
Details | Review

[Affected versions]:

  • Nightly 105.01a

[Affected Platforms]:

  • Mac 12.4
  • Windows 10 x64
  • Linux Mint 20

[Prerequisites]:

  • Have the "DB Browser for SQLite" software installed/extracted.
  • Have a new Firefox Profile created.
  • Have the "places.sqlite" file from the new profile directory opened in "DB Browser for SQLite".
  • Have a VPN set to the US country.

[Steps to reproduce]:

  1. Open the Nightly browser.
  2. Middle click on a Sponsored tile displayed in the "about:newtab" page.
  3. Focus the "DB Browser for SQLite", in "Browse Data" tab select "moz_historyvisits" table.
  4. Refresh the database and observe the last value added in the "source" column.

[Expected result]:

  • The source has value 1.

[Actual result]:

  • The source has value 1.

[Notes]:

  • Attached is a screen recording of the issue.
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Attachment #9289605 - Attachment description: Bug 1784242: Make opening in new tab by middle click eligible for inheritance of sponsored session. → Bug 1784242: Make opening in new tab by middle click target for inheritance of sponsored session.
Attachment #9289606 - Attachment description: Bug 1784242: Make opening in new tab by context menu on tile eligible for inheritance of sponsored session. → Bug 1784242: Make opening in new tab by context menu on tile target for inheritance of sponsored session.
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0722fc4bb4fa
Make opening in new tab by middle click target for inheritance of sponsored session. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/f19a8a76a85b
Make opening in new tab by context menu on tile target for inheritance of sponsored session. r=daleharvey

Backed out for causing node newtab failures

Backout link

Push with failures

Failure log

Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c85026ef0f1
Make opening in new tab by middle click target for inheritance of sponsored session. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/69f7115e5814
Make opening in new tab by context menu on tile target for inheritance of sponsored session. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/8c85026ef0f1
https://hg.mozilla.org/mozilla-central/rev/69f7115e5814

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox105: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

I have verified this issue using the latest Nightly 105.0a1 build (Build ID: 20220816095503) on Windows 10 x64, macOS 12.4 and Linux Mint 20 x64.

  • This issue is no longer reproducible. If a Sponsored tile is opened in a new tab using the middle click the source has value 1.
Status: RESOLVED → VERIFIED
status-firefox105: fixed → verified
You need to log in before you can comment on or make changes to this bug.