1784242 - If a Sponsored tile is opened in a new tab using middle click the source has value 0

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: opening a sponsored tile with middle click.mp4

[Affected versions]:

• Nightly 105.01a

[Affected Platforms]:

• Mac 12.4
• Windows 10 x64
• Linux Mint 20

[Prerequisites]:

• Have the "DB Browser for SQLite" software installed/extracted.
• Have a new Firefox Profile created.
• Have the "places.sqlite" file from the new profile directory opened in "DB Browser for SQLite".
• Have a VPN set to the US country.

[Steps to reproduce]:

1. Open the Nightly browser.
2. Middle click on a Sponsored tile displayed in the "about:newtab" page.
3. Focus the "DB Browser for SQLite", in "Browse Data" tab select "moz_historyvisits" table.
4. Refresh the database and observe the last value added in the "source" column.

[Expected result]:

• The source has value 1.

[Actual result]:

• The source has value 1.

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1784242: Make opening in new tab by middle click target for inheritance of sponsored session.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1784242: Make opening in new tab by context menu on tile target for inheritance of sponsored session.

Depends on D154486

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0722fc4bb4fa
Make opening in new tab by middle click target for inheritance of sponsored session. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/f19a8a76a85b
Make opening in new tab by context menu on tile target for inheritance of sponsored session. r=daleharvey

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing node newtab failures

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c85026ef0f1
Make opening in new tab by middle click target for inheritance of sponsored session. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/69f7115e5814
Make opening in new tab by context menu on tile target for inheritance of sponsored session. r=daleharvey

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8c85026ef0f1
https://hg.mozilla.org/mozilla-central/rev/69f7115e5814

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue using the latest Nightly 105.0a1 build (Build ID: 20220816095503) on Windows 10 x64, macOS 12.4 and Linux Mint 20 x64.

• This issue is no longer reproducible. If a Sponsored tile is opened in a new tab using the middle click the source has value 1.