1784250 - [wpt-sync] Sync PR 35432 - Support replaced content in repeated (NG) table sections.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35432 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35432
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Support replaced content in repeated (NG) table sections.

For now we attempt to only support regular images, and prevent any other
type of replaced content (including form elements) and scrollable
containers from being repeated, so that we only paint / hit-test in the
first fragmentainer. Or at least don't crash.

This requires us to simplify the PaintInfo::FragmentToPaint() logic. We
previously had some special code that DCHECKed that legacy objects don't
create multiple fragments (and simply returned the first FragmentData),
but since multiple fragments is now possible, we'll allow it, under the
assumption that someone has set the correct fragment ID in PaintInfo
when looking up FragmentData via LayoutObject.

Also had to make some changes in pre-paint, so that we don't leave
fragment traversal at NG objects, even if CanTraversePhysicalFragments()
is false. This is mainly to avoid DCHECK failures -- we'll fail to get
this right for certain types of repeated replaced content, but that's
fine, as long as CanPaintMultipleFragments() returns false in such
cases.

This CL makes two existing tests pass. Also added a "tentative"
correctness test for repeated images, and added a crash test for a lot
of other types of repeated replaced content, and also repeated
scrollable containers, as there are quite a few reasons why the engine
doesn't support repeating those correctly.

Bug: 1334547
Change-Id: Ia86a668b842f4566957b028a03dc51e641a58652
Reviewed-on: https://chromium-review.googlesource.com/3826300
WPT-Export-Revision: f1ede2f8c9293c68e3017cbfb2d0b9da080f6df4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=598c1463548113d8dcd86485311f8534533356ad

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 2

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/table/repeated-section/image.tentative.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37fbf7939046
[wpt PR 35432] - Support replaced content in repeated (NG) table sections., a=testonly
https://hg.mozilla.org/integration/autoland/rev/f36f211744ea
[wpt PR 35432] - Update wpt metadata, a=testonly

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/37fbf7939046
https://hg.mozilla.org/mozilla-central/rev/f36f211744ea