1784254 - Make `page_action` and `hidden` mutually exclusive

Status: RESOLVED FIXED

(WebExtensions :: General, task, P3)

Description

[William Durand [:willdurand]]

Similar to Bug 1781998 in which we made hidden and browser_action (or action) mutually exclusive, we should also make page_action and hidden mutually exclusive.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1784254 - Make `page_action` and `hidden` mutually exclusive. r?mixedpuppy!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d369086884f0
Make `page_action` and `hidden` mutually exclusive. r=mixedpuppy

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d369086884f0

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1784254 - Skip page action parts of test when run in Thunderbird. r=willdurand

Thunderbird doesn't have page actions, so these parts of the test fail.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bb9b9a2db62
Skip page action parts of test when run in Thunderbird. r=willdurand,extension-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0bb9b9a2db62