1784369 - Make new window target for inheritance of sponsored sessions

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Description

[Daisuke Akatsuka (:daisuke)]

Currently, if user opens sponsored tile/link in a new tab, we handle the visit as “sponsored“, but not in new window. We make the new window eligible for the inheritance of sponsored sessions.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1784369: Make opening in new window target for inheritance of sponsored sessions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d4131b0ca28
Make opening in new window target for inheritance of sponsored sessions. r=daleharvey

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing node newtab failures

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b318aba23400
Make opening in new window target for inheritance of sponsored sessions. r=daleharvey

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b318aba23400

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue using the latest Nightly 105.0a1 build (Build ID: 20220816095503) on Windows 10 x64, macOS 12.4 and Linux Mint 20 x64.

• The source and triggringPlaceId are correctly populated if the link is opened from the Firefox context menu -> "Open in a New Window" option.

However, it seems that if a Sponsored tile is opened in a new window from the tile menu -> "Open in a New Window", the source has value 0 and triggringPlaceId is NULL.
@Daisuke please let me know if I should log a separate issue for opening the Sponsored tile in a new window from the tile menu.

I will mark this bug as verified - fixed and we will track the scenario mentioned above in a separate one if needed.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Oh, indeed!
Thank you very much for catching this, Cosmin!

@Daisuke please let me know if I should log a separate issue for opening the Sponsored tile in a new window from the tile menu.

Yes, please! Or, I will file it.

Comment 8

[Daisuke Akatsuka (:daisuke)]

I filed bug 1785165.