If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[mach] Mach-0 mozilla ignores startup prefs

VERIFIED FIXED in mozilla1.2final

Status

()

Core
Preferences: Backend
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Conrad Carlen (not reading bugmail), Assigned: Conrad Carlen (not reading bugmail))

Tracking

Trunk
mozilla1.2final
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
Mozilla only enumerates the general.startup.* prefs (those set in the prefs UI)
if the program receives the default number of args. "Default" is considered to be 1.
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsAppRunner.cpp#1470
But the Mach-0 build, if double-clicked from the Finder, is passed 2 args so we
don't read these prefs.
(Assignee)

Comment 1

15 years ago
Taking.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2final
(Assignee)

Comment 2

15 years ago
Created attachment 105192 [details] [diff] [review]
patch

This fixes it on 10.2. Can anybody with a 10.1 system test whether we get
passed the psn arg on 10.1 as well?

Comment 3

15 years ago
Comment on attachment 105192 [details] [diff] [review]
patch

r=sdagley (ccarlen and I discussed the PSN compare and he's convinced me the
sprintf is less overhead than a scanf)

And verified this will work on 10.1 as we get 2 args there with the 2nd being
the PSN
Attachment #105192 - Flags: review+

Comment 4

15 years ago
Comment on attachment 105192 [details] [diff] [review]
patch

sr=sfraser
Attachment #105192 - Flags: superreview+
Component: Browser-General → Preferences: Backend
QA Contact: asa → sairuh

Comment 5

15 years ago
Comment on attachment 105192 [details] [diff] [review]
patch

a=asa for checkin to the 1.2 branch (on behalf of drivers).
Attachment #105192 - Flags: approval+
(Assignee)

Updated

15 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

15 years ago
Checked into 1.2 branch.
out of curiosity, should this be checked into the trunk as well? (unless you
already did so earlier. :)
(Assignee)

Comment 8

15 years ago
It went into the trunk already.
okay, good.

rs vrfy (checked lxr) with 2002.11.18.14 (trunk, mach-o).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.