1784873 - [Wayland] xdg_popup (menu) fails to show/move when positioned by gtk_window_move()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Popups with remote content positioned by gtk_window_move() doesn't show child popups.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Screencast from 08-15-2022 02:35:31 PM.webm

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1760276

Comment 3

[Martin Stránský [:stransky] (ni? me)]

The bug here is caused by GDK_WINDOW_TYPE_HINT_UTILITY -> GDK_WINDOW_TYPE_HINT_POPUP_MENU switch. GDK_WINDOW_TYPE_HINT_POPUP_MENU needs extra hide/show cycle when it's positioned by gtk_window_move().

Comment 4

[Martin Stránský [:stransky] (ni? me)]

https://gitlab.gnome.org/GNOME/gtk/-/issues/5089 is related.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

As a workaround we need to use move-to-rect for popups attached to another popups - so we can't use subsurface popups.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1784873 [Wayland] Don't hide & position popups which are on correct position r?emilio

Extra hide/show needed for gtk_window_move() produces extra flickering so avoid it if possible.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1784873 [Wayland] Implement nsWindow::WaylandPopupIsFirst() helper to check popup state in popup hierarchy r?emilio

Depends on D154879

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1784873 [Wayland] Allow to use fast popup placement (without move-to-rect) for first popup only due to mutter bug r?emilio

Due to https://gitlab.gnome.org/GNOME/gtk/-/issues/5089 we can't use fast popup placement for nested popups.
Only first popup can be placed by gtk_window_move().

Depends on D154880

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1784873 [Wayland] Remove outdated check for move-to-rect r?emilio

Remove outdated check for move-to-rect. It's redundant and it's implemented in more complex way by nsWindow::WaylandPopupCheckAndGetAnchor() now.

Depends on D154881

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d74ad17ab62b
[Wayland] Don't hide & position popups which are on correct position r=emilio
https://hg.mozilla.org/integration/autoland/rev/d619864bd63e
[Wayland] Implement nsWindow::WaylandPopupIsFirst() helper to check popup state in popup hierarchy r=emilio
https://hg.mozilla.org/integration/autoland/rev/f37681634e20
[Wayland] Allow to use fast popup placement (without move-to-rect) for first popup only due to mutter bug r=emilio
https://hg.mozilla.org/integration/autoland/rev/406524c83203
[Wayland] Remove outdated check for move-to-rect r=emilio

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d74ad17ab62b
https://hg.mozilla.org/mozilla-central/rev/d619864bd63e
https://hg.mozilla.org/mozilla-central/rev/f37681634e20
https://hg.mozilla.org/mozilla-central/rev/406524c83203