1784882 - Drop globalKeys.dtd

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Eemeli Aro [:eemeli]]

The MozDialog widget /toolkit/content/widgets/dialog.js is one of the few remaining users of DTD strings for localization (from globalKeys.dtd), and should be migrated to Fluent.

Comment 1

[Eemeli Aro [:eemeli]]

As an interesting note, this will be a bit challenging to fully test, as there is no code path in mozilla-central or its tests that actually uses the strings that will be migrated. The only remaining ones set the key shortcut for simulating a click on the optional help button of a <dialog>, and no such button is currently used in mozilla-central.

The code isn't completely unused, though, as there are a few dialogs in comm-central that do contain a help button.

Comment 2

[Magnus Melin [:mkmelin]]

Thunderbird doesn't use help from dialogs like that.

But, not one single localization changed either of those keys. It could be either dropped or hardcoded.
https://searchfox.org/l10n/search?q=openHelp.commandkey&path=&case=false&regexp=false
https://searchfox.org/l10n/search?q=openHelpMac.commandkey&path=&case=false&regexp=false

Comment 3

[Eemeli Aro [:eemeli]]

The uses in comm-central are all for SeaMonkey:
https://searchfox.org/comm-central/search?q=dlgtype%3D%22help%22

Comment 4

[Magnus Melin [:mkmelin]]

They are not really releasing. Still based on 56.

Comment 5

[Eemeli Aro [:eemeli]]

Attachment: Bug 1784882 - Drop MozDialog help button. r=jaws,mkmelin

The <dialog> help button is not used by Firefox or Thunderbird,
and its behaviour is untested.

Comment 6

[Eemeli Aro [:eemeli]]

Attachment: Bug 1784882 - Drop global styles for dlgtype="help". r=jaws

After removing the button from MozDialog, the only remaining use in
PageInfo is turned into a local class style.

Depends on D154871

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34eaa0325a11
Drop MozDialog help button. r=mkmelin,dao
https://hg.mozilla.org/integration/autoland/rev/cab76b448c70
Drop global styles for dlgtype="help". r=desktop-theme-reviewers,dao

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/34eaa0325a11
https://hg.mozilla.org/mozilla-central/rev/cab76b448c70