1785165 - Make new window by context menu of tile be target to inheritance of sponsored session

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Description

[Daisuke Akatsuka (:daisuke)]

In bug 1784369, we supported new window to inherit sponsored session.
However, we forgot to support new window by context menu of tile in newtab.
In this bug, implement it.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01420503a289
Make new window by context menu of tile be target to inheritance of sponsored session. r=daleharvey

Comment 3

[Iulian Moraru]

Backed out for causing node - newtab failures.

Push with failures

Failure log

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a659ed26b71a
Make new window by context menu of tile be target to inheritance of sponsored session. r=daleharvey

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a659ed26b71a

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 105.0a1 build (Build ID: 20220821185924) on Windows 10 x64, macOS 12.4 and Linux Mint 20.

• The source has value "0" if the Sponsored tile is opened in a new window using the tile's menu.

Comment 7

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9290215 [details]
Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session.

Beta/Release Uplift Approval Request

• User impact if declined: When user opens a sponsored tile in a new window from its context menu, it is not handled correctly as sponsored link, the display priority does not change.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The main changes are only two lines. And also, it affects for only opening a new window from the context menu that tile on about:home has.
• String changes made/needed: no
• Is Android affected?: No

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9290215 [details]
Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session.

This landed on m-c prior to the 105 uplift to Beta.